Skip to content

Conversation

@darrachequesne
Copy link
Member

@kapouer
Copy link
Contributor

kapouer commented Oct 5, 2015

Hello, changing the broadcast API (from arrays to objects) doesn't improve performance, breaks all other adapters, and it is possible to not change the API and yet change the internal self.rooms to an object.

@darrachequesne
Copy link
Member Author

Hi! After second thoughts, I guess you're right, since rooms and except contains a priori not many elements (and the change of rooms -- and not _rooms -- from array to object is indeed possible without this).
Thanks! I close this now.

@darrachequesne darrachequesne deleted the issue-2199 branch October 8, 2015 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants