-
Notifications
You must be signed in to change notification settings - Fork 10.1k
converted arrays to objects #2239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9b839ee to
702818f
Compare
702818f to
c6bc3e9
Compare
|
Wouldn't it be better to use a |
d481a18 to
a1c38a2
Compare
|
Object would be better for now, since there is no |
|
@nkzawa yes, that's my opinion too 👍 If we'd want to use ̀Map` (and more generally the ES2015 features) and still keep support of node < 0.12, I think a migration to Babel (or other) would be necessary (but that's out of the scope here) |
|
In the meantime we can merge this. |
a2e98f2 to
cecdca3
Compare
cecdca3 to
b73d9be
Compare
|
Done! 👼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not checking for hasOwnProperty here. Extensions fo the natives will make socket.io break here. Test needed for that scenario as well.
|
Hi! I opened a new PR to clean this ugly one: #2322 |

See #2199