Always extract ancestor handlers on Android #1710
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-piasecki
added a commit
that referenced
this pull request
Jun 15, 2022
…s='box-none'` (#2024) As described in the [docs](https://reactnative.dev/docs/view#pointerevents), when a view has `pointerEvents` prop set to `box-none` then it will never be a touch target but its children might be. Current implementation ignores gestures attached to the view with `pointerEvents='box-none'` entirely, even if its child is handling events, contrary to how it works on iOS where the gestures attached to parent will also work on the child view (but not on the parent). This PR changes implementation of the view traversing algorithm to also extract gestures from a view with `pointerEvents='box-none'` when the target of a touch is its descendant. Fixes #1575. Supersedes #1710.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently handlers attached to the ancestors of a view are extracted only if the view overflows its parent as described in #1618. There is at least one more use-case where that would be a desirable behavior: if the view has
pointer-eventsprop set tobox-nonethen the view itself cannot become the target of touch events but its children can, however currently any gesture handler attached to that view would not be extracted when its child captures a touch event.An example of this can be found in this issue: #1000 (note that this PR does not fully resolve this issue as there are more things to be addressed there).
Test plan
Tested on the Example app and on slightly modified code from the linked issue (imported touchables and flatlist from
react-native-gesture-handlerinstead ofreact-native).