Extract handlers when child view is handling touch with pointerEvents='box-none'
#2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmagiera
approved these changes
Jun 14, 2022
j-piasecki
deleted the
@jpiasecki/pointer-events-none-extract-parent-handlers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As described in the docs, when a view has
pointerEventsprop set tobox-nonethen it will never be a touch target but its children might be. Current implementation ignores gestures attached to the view withpointerEvents='box-none'entirely, even if its child is handling events, contrary to how it works on iOS where the gestures attached to parent will also work on the child view (but not on the parent).This PR changes implementation of the view traversing algorithm to also extract gestures from a view with
pointerEvents='box-none'when the target of a touch is its descendant.Fixes #1575. Supersedes #1710.
Test plan
Tested on the Example app.