Skip to content

Add notice for old API users #1817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jgonet merged 2 commits into from
Jan 11, 2022
Merged

Add notice for old API users #1817

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7726ecb
Add notice for old API users
jgonet Jan 11, 2022
1dc8034
Move __DEV__ condition to caller
jgonet Jan 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/handlers/createHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,16 @@ type InternalEventHandlers = {
onGestureHandlerStateChange?: (event: any) => void;
};

let showedRngh2Notice = false;
function showRngh2NoticeIfNeeded() {
if (!showedRngh2Notice) {
console.warn(
"[react-native-gesture-handler] Seems like you're using an old API with gesture components, check out new Gestures system!"
);
showedRngh2Notice = true;
}
}

// TODO(TS) - make sure that BaseGestureHandlerProps doesn't need other generic parameter to work with custom properties.
export default function createHandler<
T extends BaseGestureHandlerProps<U>,
Expand Down Expand Up @@ -162,6 +172,9 @@ export default function createHandler<
}
handlerIDToTag[props.id] = this.handlerTag;
}
if (__DEV__) {
showRngh2NoticeIfNeeded();
}
}

componentDidMount() {
Expand Down