This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix non-determinism in account_hash_ignore_slot on genesis #32801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jeffwashington Here's an example on how to fix bug #32800. I won't be able to address review comments, so if this PR needs changes, please close and reopen. |
Contributor
Author
|
Confirmed with Firedancer that this fix works. |
github-actions
bot
added
the
stale
|
|
||
| // Make sure to activate the account_hash_ignore_slot feature | ||
| // before calculating any account hashes. | ||
| // TODO should also check feature activation slot here, in case |
Contributor
There was a problem hiding this comment.
how would you check feature activation slot here?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #32800