This repository was archived by the owner on Jan 22, 2025. It is now read-only.
Fix non-determinism in account_hash_ignore_slot on genesis #33692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #33692 +/- ##
=========================================
- Coverage 81.8% 81.8% -0.1%
=========================================
Files 806 806
Lines 217676 217679 +3
=========================================
- Hits 178220 178200 -20
- Misses 39456 39479 +23 |
ripatel-fd
approved these changes
Oct 13, 2023
Contributor
ripatel-fd
left a comment
ripatel-fd
left a comment
There was a problem hiding this comment.
This looks good. But it might be worth confirming that this behaves correctly in case feature activation is scheduled in a future slot. (Which I believe is the second parameter of the tuple here (pubkey, _))
Contributor
Author
tuple.1 is the account itself. solana/sdk/src/genesis_config.rs Line 92 in a60d185 |
mergify bot
pushed a commit
that referenced
this pull request
Oct 16, 2023
(cherry picked from commit 69495f4)
jeffwashington
added a commit
that referenced
this pull request
Oct 16, 2023
(cherry picked from commit 69495f4)
mergify bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
(cherry picked from commit 69495f4)
jeffwashington
added a commit
that referenced
this pull request
Oct 19, 2023
…ckport of #33692) (#33728) Fix non-determinism in account_hash_ignore_slot on genesis (#33692) (cherry picked from commit 69495f4) Co-authored-by: Jeff Washington (jwash) <[email protected]>
jeffwashington
added a commit
that referenced
this pull request
Oct 19, 2023
…ckport of #33692) (#33720) Fix non-determinism in account_hash_ignore_slot on genesis (#33692) (cherry picked from commit 69495f4) Co-authored-by: Jeff Washington (jwash) <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #32801
until the
account_hash_ignore_slotfeature gets activated, there is some non-determinism in testing.Summary of Changes
Remove non-determinism.
Fixes #32800