v1.16: Fix non-determinism in account_hash_ignore_slot on genesis (backport of #33692)

[mergify]

This is an automatic backport of pull request #33692 done by Mergify.

---

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

• @Mergifyio refresh will re-evaluate the rules
• @Mergifyio rebase will rebase this PR on its base branch
• @Mergifyio update will merge the base branch into this PR
• @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

• look at your merge queues
• generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

[codecov]

Codecov Report

Merging #33728 (3d95e07) into v1.16 (08876b9) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            v1.16   #33728   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         766      766           
  Lines      209091   209094    +3     
=======================================
+ Hits       171144   171165   +21     
+ Misses      37947    37929   -18     

[brooksprumo]

Lgtm. I'll let Will have the final say.

[willhickey]

I see that this code is mostly used by tests, but is it possible that this call in process_blockstore_for_bank_0 could be used in a non-test environment by someone attempting to process an entire ledger history? In that case I think this PR changes consensus, right?

[jeffwashington]

I see that this code is mostly used by tests, but is it possible that this call in process_blockstore_for_bank_0 could be used in a non-test environment by someone attempting to process an entire ledger history? In that case I think this PR changes consensus, right?

First, the feature account would need to be in the genesis account list for this code to change anything (activate the feature in this case). No running networks have that account in their genesis account list.

Second, I don't think it is possible to process a blockstore from slot 0 for testnet, devnet, mnb. Nobody has that entire ledger anywhere that I'm aware of.

@t-nelson, @brooksprumo can either of you please confirm?

[willhickey]

First, the feature account would need to be in the genesis account list for this code to change anything

Ah yes, that's the detail I was missing.

LGTM

[t-nelson]

First, the feature account would need to be in the genesis account list for this code to change anything (activate the feature in this case). No running networks have that account in their genesis account list.

correct

Second, I don't think it is possible to process a blockstore from slot 0 for testnet, devnet, mnb. Nobody has that entire ledger anywhere that I'm aware of.

incorrect. this should be doable for mb. it would require using a sw version from the same era as the blocks were generated, but we have most of the data in a playable form