Add old base fee storage killing

Signed-off-by: Daniil Polyakov <[email protected]>

pallets/xst/src/migrations/mod.rs

@@ -29,19 +29,28 @@
 // USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 use super::pallet::{Config, Pallet};
-use common::{fixed, XSTUSD};
+use common::generate_storage_instance;
+use common::{fixed, Fixed, XSTUSD};
 use frame_support::pallet_prelude::{Get, StorageVersion};
+use frame_support::pallet_prelude::{StorageValue, ValueQuery};
 use frame_support::{log::info, traits::GetStorageVersion as _, weights::Weight};
 
 use crate::{EnabledSymbols, EnabledSynthetics, SyntheticInfo};
 
+generate_storage_instance!(PoolXST, BaseFee);
+type OldBaseFee = StorageValue<BaseFeeOldInstance, Fixed, ValueQuery>;
+
 /// Migration which migrates `XSTUSD` synthetic to the new format.
 pub fn migrate<T: Config>() -> Weight {
     if Pallet::<T>::on_chain_storage_version() >= 2 {
         info!("Migration to version 2 has already been applied");
         return 0;
     }
 
+    if OldBaseFee::exists() {
+        OldBaseFee::kill();
+    }
+
     EnabledSynthetics::<T>::insert(
         T::AssetId::from(XSTUSD),
         Some(SyntheticInfo {

pallets/xst/src/migrations/tests.rs

@@ -28,14 +28,15 @@
 // STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE
 // USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-use crate::{mock::*, pallet::Pallet, EnabledSynthetics};
-use common::{fixed, XSTUSD};
+use crate::{migrations::OldBaseFee, mock::*, pallet::Pallet, EnabledSynthetics};
+use common::{fixed, Fixed, XSTUSD};
 use frame_support::traits::{GetStorageVersion as _, StorageVersion};
 
 #[test]
 fn test() {
     ExtBuilder::default().build().execute_with(|| {
         StorageVersion::new(1).put::<Pallet<Runtime>>();
+        OldBaseFee::put::<Fixed>(fixed!(0.00666));
 
         super::migrate::<Runtime>();
 
@@ -44,6 +45,7 @@ fn test() {
 
         assert_eq!(info.reference_symbol, "USD");
         assert_eq!(info.fee_ratio, fixed!(0.00666));
+        assert!(!OldBaseFee::exists());
 
         assert_eq!(Pallet::<Runtime>::on_chain_storage_version(), 2);
     });