Trading pair source trait #801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge develop to master
…ra-xor/sora2-network into prepare-release-3.1.0
wer1st
reviewed
Oct 25, 2023
| [package] | ||
| name = "framenode" | ||
| version = "3.0.0" | ||
| version = "3.1.0" |
Contributor
There was a problem hiding this comment.
You don't need to change the version of any pallet in this scope
Comment on lines
+259
to
+262
| spec_version: 66, | ||
| impl_version: 1, | ||
| apis: RUNTIME_API_VERSIONS, | ||
| transaction_version: 64, | ||
| transaction_version: 66, |
Contributor
There was a problem hiding this comment.
Please revert it. We have a special process where we update these values
Contributor
Author
|
I moved this draft to new PR #808, kindly check. Pumping versions appears here because I did a wrong branch-out before opening the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the TradingPairSourceManager trait to pallet configs in order to avoid direct calls from the trading-pair pallet.