Skip to content

Conversation

@TheLedgerOfJoudi
Copy link
Contributor

I moved the draft PR #801 here with the correct branching out of develop. This PR holds a better descriptive name, as well, as I added more traits to resolve the clear dependency.

@wer1st
Copy link
Contributor

wer1st commented Oct 30, 2023

You missed the important part - the removing of build dependecies in Cargo.toml

@TheLedgerOfJoudi
Copy link
Contributor Author

Removed trading_pair::Config as a supertrait in src/lib.rs from all pallets.
Removed trading_pair as a build dependency from pallets which do not require it in mock initializations.
T::Trait is requiring fully qualified path for disambiguation because the type could derive from multiple pallet configs.

@wer1st wer1st self-requested a review December 4, 2023 09:57
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@vovac12 vovac12 merged commit e420a1d into develop Dec 4, 2023
@vovac12 vovac12 deleted the removing-trading-pair-dependency branch December 4, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants