-
Notifications
You must be signed in to change notification settings - Fork 28
Removing trading pair dependency #808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You missed the important part - the removing of build dependecies in |
|
Removed trading_pair::Config as a supertrait in src/lib.rs from all pallets. |
…ving-trading-pair-dependency
…r/sora2-network into removing-trading-pair-dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
I moved the draft PR #801 here with the correct branching out of develop. This PR holds a better descriptive name, as well, as I added more traits to resolve the clear dependency.