Skip to content

Fix imported circular iteration convergence - #40

Merged
cloudbring merged 1 commit into
mainfrom
algo/gridcraft-formula-295-297
Nov 9, 2026
Merged

cloudbring merged 1 commit into
mainfrom
algo/gridcraft-formula-295-297

Conversation

@cloudbring

Copy link
Copy Markdown

Fixes storytold#295.

Excel recalculates 57535.xlsx!Sheet1!E5 to 1.3333333326 and E6 to 7.3333333326 with the workbook's omitted iteration settings (Excel showed 100 iterations and Maximum Change 0.001). GridCraft had stopped as soon as the cached circular values fell below the tolerance, before updates propagated through the loop.

This keeps the 0.001 default and applies a minimum pass count only on initial imported-workbook calculation, based on the longest circular cycle found. A regression test uses the Excel values and the original cached seeds.

Validation:

  • cargo test -p gridcraft-calc: 132 passed, 1 ignored.
  • 993-workbook Excel-reconciled A/B: 68,150 formula values, 1,614 mismatches on both baseline and candidate, zero new mismatch keys, zero round-trip failures.
  • The raw source-cache A/B has one added mismatch at 57535.xlsx!E6, where the source cache is stale versus Excel. The candidate result matches Excel within the corpus tolerance.
  • Local cargo xtask ci hit the known Linux U+1E9E font test (hyper#258); the Hosted CI workflow documents its skip for that environment test.

@cloudbring
cloudbring merged commit 9053478 into main Nov 9, 2026
1 check passed
@cloudbring
cloudbring deleted the algo/gridcraft-formula-295-297 branch November 9, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant