Repository navigation
Fix imported circular iteration convergence - #40
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes storytold#295.
Excel recalculates
57535.xlsx!Sheet1!E5to1.3333333326andE6to7.3333333326with the workbook's omitted iteration settings (Excel showed 100 iterations and Maximum Change0.001). GridCraft had stopped as soon as the cached circular values fell below the tolerance, before updates propagated through the loop.This keeps the
0.001default and applies a minimum pass count only on initial imported-workbook calculation, based on the longest circular cycle found. A regression test uses the Excel values and the original cached seeds.Validation:
cargo test -p gridcraft-calc: 132 passed, 1 ignored.57535.xlsx!E6, where the source cache is stale versus Excel. The candidate result matches Excel within the corpus tolerance.cargo xtask cihit the known Linux U+1E9E font test (hyper#258); the Hosted CI workflow documents its skip for that environment test.