Repository navigation
View: Formula Bar and Zoom 100% as engine commands (#289) - #295
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 11, 2026
Merged
Conversation
- view.zoom100 sets the active sheet's zoom to 100% (the ribbon's 100%
button runs it).
- view.formulaBar {on?} toggles a formulaBar preference (Prefs, saved in
prefs.json on desktop; an application option, not in the file). The UI
shows the formula bar from it; the ribbon checkbox, native menu and
ui.set {formulaBar} go through the command.
- The UI-only interceptions and their entries in engine.commands are gone,
so the CLI and MCP can run both. Parity checklist regenerated (260 / 290).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Merged — thank you for the contribution! (I resolved a conflict with #294 in control.rs/lib.rs — the UI-level view.zoom100 handler is gone now that it's an engine command.) If you haven't already, come join us on the ArtCraft Discord: https://discord.gg/artcraft |
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 11, 2026
…after #295) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289
view.formulaBar(View › Show › Formula Bar) andview.zoom100(View › Zoom › 100%) already worked in the desktop UI, but only as UI-only commands. Headless sessions (CLI, MCP) couldn't run them, and the parity catalog didn't count them. Both are now engine commands (catalog 258 → 260 / 290, View 18/20 → 20/20).What changed
view.zoom100({}→{zoom}): sets the active sheet's zoom to 100%, the same asview.zoom {percent: 100}. The ribbon's 100% button now runs it.view.formulaBar({on?: bool}→{on}): toggles a newformulaBarpreference inPrefs(default shown). Excel keeps this as an application option, so it's not saved in the workbook. It runs without an open workbook (enabled: always).session.prefs.formula_bar. The ribbon checkbox runs the command, and so do the native menu (unchanged, it already ranview.formulaBar) and the control channel'sui.set {formulaBar}(its response still includesformulaBar). I removed the UI-only interceptions and their duplicate entries inengine.commands, and droppedUiState.formula_bar.docs/parity-checklist.md; catalog number and revision rows indocs/target-app-parity.mdandROADMAP.md(plus a progress-log row); a note indocs/control-protocol.md.Tests
cmd::view::tests::zoom_100_resets_the_active_sheet_zoomcmd::view::tests::formula_bar_toggles_without_a_workbook_and_defaults_to_shown: also checks that aprefs.jsonsaved before the option existed keeps the formula bar shown.tests::every_command_survives_empty_paramscovers both commands.Commands run (touched crates only):
cargo test -p gridcraft-engine --lib(127 passed)cargo test -p gridcraft-ui-egui --lib(21 passed)cargo clippy -p gridcraft-engine -p gridcraft-ui-egui -p gridcraft --all-targets -- -D warningscargo fmt -p gridcraft-engine -p gridcraft-ui-egui -- --checkcargo xtask parity/--checkview.zoom {150},view.zoom100,view.formulaBar {}: formula bar hidden, checkbox cleared, zoom 100%. Checked by eye.Not done / notes
ui.json(UiState) toprefs.json(Prefs), and there is no migration.ROADMAP.md/docs/target-app-parity.md. Whichever merges second needs a rebase, and I'll do it.Unverified assumptions
🤖 Generated with Claude Code