Added new resource to manage lookup table files #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rrossetti-splunk Please review this PR. The last time you ran the Build and Test, master was in a broken state. I have successfully run the test GH action on my branch. |
rrossetti-splunk
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Is this an example of using the new resource? Can you include it in the examples directory if so.
There was a problem hiding this comment.
It is not an example. This terraform folder is volume mounted into the ACC test container and terraform is applied on the container to install the Splunk lookup app, which is required for the TestAccSplunkLookupTableFile test to pass.
There was a problem hiding this comment.
@rrossetti-splunk Do you need anything else from me to get this PR merged?
rrossetti-splunk
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.