Skip to content

Added new resource to manage lookup table files #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 8, 2024
Merged

Added new resource to manage lookup table files #196

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d86e3f7
Added new resource to manage lookup table files
akohring Oct 2, 2024
96e9399
Corrected typo in documentation
akohring Oct 2, 2024
4df8afc
Removed whitespace trim since it is not needed
akohring Oct 2, 2024
6b167f4
Updated lookup read to detect remote changes
akohring Oct 2, 2024
91aa551
Converted lookup table file_contents usage from a string to a [][]string
akohring Oct 3, 2024
777f453
Added splunk app for lookup file editing
akohring Oct 10, 2024
cb11060
Fixed missing quote
akohring Oct 10, 2024
dcce27e
Added names to terraform workflow steps
akohring Oct 10, 2024
85e0907
Moved terraform chdir to global options
akohring Oct 10, 2024
b7cfd79
Added volume mount for app addons
akohring Oct 10, 2024
b0bb140
Reworked service volume mount
akohring Oct 10, 2024
67609fd
Merge branch 'splunk:master' into lookup-table-file
akohring Nov 7, 2024
fa2d660
Updated changelog
akohring Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added volume mount for app addons
  • Loading branch information
@akohring
akohring committed Oct 10, 2024
commit b7cfd79200c9c06d66c8c29309ffbe41a244afac
2 changes: 2 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:
ports:
- 8000:8000
- 8089:8089
volumes:
- ${{ github.workspace }}/terraform/apps:/apps

steps:
- name: Set up Go 1.x
Expand Down
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Ignore dist file
.idea
.terraform
.terraform.lock.hcl
dist
terraform-provider-splunk
terraform.tfstate
Expand Down
2 changes: 1 addition & 1 deletion terraform/main.tf
View file
Open in desktop
Copy link
Collaborator

@rrossetti-splunk rrossetti-splunk Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an example of using the new resource? Can you include it in the examples directory if so.

Copy link
Contributor Author

@akohring akohring Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not an example. This terraform folder is volume mounted into the ACC test container and terraform is applied on the container to install the Splunk lookup app, which is required for the TestAccSplunkLookupTableFile test to pass.

Copy link
Contributor Author

@akohring akohring Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rrossetti-splunk Do you need anything else from me to get this PR merged?

Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@ provider "splunk" {
resource "splunk_apps_local" "lookup_file_editing" {
filename = true
name = "/apps/splunk-app-for-lookup-file-editing_404.tgz"
explicit_appname = "Splunk App for Lookup File Editing"
explicit_appname = "splunk-app-for-lookup-file-editing"
}