Skips docker's interfaces #67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The valid IP can be used for communicating w/ docker and w/ the outside, which is probably what you want when developing
Member
|
@dsyer @adriancole @marcingrzejszczak This pains me that I wrote this as a static method. I'd like to make the interfaces to skip configurable. Should I add a parameter that takes a configuration properties object, or move this to a bean? As I type the question, the answer seems to me to move it to a bean if I'm going to make it configurable. |
Contributor
|
Yep. It's not too late for 1.1.0. The ship has sailed on Brixton.M4 I think (so please don't change the architecture in anything that depends on commons till after that). |
Member
|
@dsyer will do. |
spencergibb
added a commit
that referenced
this pull request
Dec 21, 2015
Member
|
Closing in favor of #75. Thanks for getting the ball rolling on this. |
spencergibb
added a commit
that referenced
this pull request
Dec 23, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The valid IP can be used for communicating w/ docker and w/ the outside, which is probably what you want when developing