Skip to content

Conversation

@spencergibb
Copy link
Member

fixes gh-67

Waiting to merge until Brixton.M4 is released.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

supernit: add javadoc or comment or rename test method to say this is to support docker overlay networks. Not sure the impact of blacklist vs whitelist on usability.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codefromthecrypt
Copy link

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to not address this now, but this will eagerly create a thread, even if never used. This is a way out, if interested: https://github.com/square/okhttp/blob/master/okhttp/src/main/java/okhttp3/internal/framed/FramedConnection.java#L156

@fiunchinho
Copy link

👍

@spencergibb
Copy link
Member Author

Closed via a42e8ea

@pcornelissen
Copy link

Will this be included in brixton.m5?
I am in desperate need for this, because as soon as I start a vpn connection on my machine all locally running spring boot instances reconfigure to this IP and are not accessible afterwards (which in itself is strange, but the routes that come with the VPN seem to be a problem). So blacklisting certain Interfaces would be great.

@spencergibb spencergibb deleted the ignore-nics branch November 28, 2017 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants