fetch heap & nonHeap memory metrics together #871
Conversation
|
@vudayani-vmw Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
...va/org/springframework/ide/vscode/boot/java/livehover/v2/SpringProcessConnectorOverHttp.java
Outdated
Show resolved
Hide resolved
...ava/org/springframework/ide/vscode/boot/java/livehover/v2/SpringProcessConnectorOverJMX.java
Outdated
Show resolved
Hide resolved
|
and CLA... @vudayani-vmw github still thinks CLA is not signed... Does the link to sign the CLA shows somewhere in the PR for you? |
|
@vudayani-vmw All looks good. Any chance you can rebase your changes on the latest from the main branch? I had issues rebasing on the latest from main. Looks like you've been doing merges rather than rebases and hence you commits are sandwiched together with commits from other folks into main branch which makes rebase difficult. |
|
@vudayani-vmw I wasn't able to do a rebase properly. However, it is not too many changes hence I factored them out into a separate PR #874. If it looks good to you (i.e. I didn't miss anything) I'll merge it instead :-) |
|
@BoykoAlex Thanks for doing this. I will keep this point in mind for the next time. |
|
Closed via #874 |
4 participants
No description provided.