Skip to content

fetch heap & nonHeap memory metrics together #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

fetch heap & nonHeap memory metrics together #871

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ad703fa
fetch heap & nonHeap memory metrics together
Nov 7, 2022
d679de9
Merge branch 'develop' of github.com:vudayani-vmw/sts4 into develop
Nov 7, 2022
00beb75
Merge branch 'spring-projects:main' into develop
vudayani Nov 8, 2022
64e8100
add null checks
Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add null checks
  • Loading branch information
V Udayani committed Nov 8, 2022
commit 64e8100b891f7178ee286f0b62ce2eb9b954adac
3 changes: 2 additions & 1 deletion ...org/springframework/ide/vscode/boot/java/livehover/v2/SpringProcessConnectorOverHttp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,8 @@ public SpringProcessMemoryMetricsLiveData refreshMemoryMetrics(SpringProcessLive
this.processName = liveData.getProcessName();
}

if (liveData != null && liveData.getHeapMemoryMetrics() != null && liveData.getHeapMemoryMetrics().length > 0 && liveData.getNonHeapMemoryMetrics().length > 0) {
if (liveData != null && liveData.getHeapMemoryMetrics() != null && liveData.getHeapMemoryMetrics().length > 0 &&
liveData.getNonHeapMemoryMetrics() != null && liveData.getNonHeapMemoryMetrics().length > 0) {
return liveData;
}
}
Expand Down
3 changes: 2 additions & 1 deletion .../org/springframework/ide/vscode/boot/java/livehover/v2/SpringProcessConnectorOverJMX.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ public SpringProcessMemoryMetricsLiveData refreshMemoryMetrics(SpringProcessLive
log.info("retrieve live data from: " + jmxURL);
SpringProcessMemoryMetricsLiveData liveData = springJMXConnector.retrieveLiveMemoryMetricsData(getProcessType(), jmxConnection, processID, processName, currentData, metricName, tags);

if (liveData != null && liveData.getHeapMemoryMetrics() != null && liveData.getHeapMemoryMetrics().length > 0 && liveData.getNonHeapMemoryMetrics().length > 0) {
if (liveData != null && liveData.getHeapMemoryMetrics() != null && liveData.getHeapMemoryMetrics().length > 0 &&
liveData.getNonHeapMemoryMetrics() != null && liveData.getNonHeapMemoryMetrics().length > 0) {
return liveData;
}
}
Expand Down