fix: Prevent shimmer after permission deny #4057
Conversation
| function AssistantMessage(props: { message: AssistantMessage; parts: Part[]; last: boolean }) { | ||
| const local = useLocal() | ||
| const { theme } = useTheme() | ||
| const inProgress = createMemo(() => !props.message.time.completed) |
There was a problem hiding this comment.
i guess this kinda works but I belive this will still be showing the wrong state sometimes during the agent loop i dont think this is the best solution
There was a problem hiding this comment.
I couldn't come up with a scenario where this is the wrong indicator, either empirically or analytically. Or even if there is such a scenario, IMO it should definitely be considered a bug in the Session.prompt loop.
An alternative solution could be to use the session busy/idle state. It has the added benefit of being robust to opening a session after abruptly closing OC where OC didn't get the chance to update the session/message states (e.g. after closing the terminal window where OC is running).
There was a problem hiding this comment.
Actually the more I think about it, the more I believe that the best solution is to make inProgress equal to isLastAssistantMessage && session.busy (pseudo code).
There was a problem hiding this comment.
Do you think this approach is reasonable?
github-actions
bot
force-pushed
the
dev
branch
from
772b621 to
eb855e1
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f1dc981 to
3e15a39
Compare
github-actions
bot
force-pushed
the
dev
branch
3 times, most recently
from
f8ee907 to
6a9856d
Compare
3 participants
Fixes #3951.