Skip to content

fix: Prevent shimmer after permission deny #4057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
veracioux wants to merge 2 commits into
base: dev
Choose a base branch
from
+11 −21
Open

fix: Prevent shimmer after permission deny #4057

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26a0a5
fix: Prevent shimmer effect after permission denial
veracioux Nov 7, 2025
6ceca31
chore: format code
actions-user Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 11 additions & 21 deletions packages/opencode/src/cli/cmd/tui/routes/session/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,8 @@ function UserMessage(props: {
function AssistantMessage(props: { message: AssistantMessage; parts: Part[]; last: boolean }) {
const local = useLocal()
const { theme } = useTheme()
const inProgress = createMemo(() => !props.message.time.completed)

return (
<>
<For each={props.parts}>
Expand Down Expand Up @@ -944,39 +946,27 @@ function AssistantMessage(props: { message: AssistantMessage; parts: Part[]; las
</Show>
<Show
when={
!props.message.time.completed ||
(props.last &&
props.parts.some((item) => item.type === "step-finish" && item.reason === "tool-calls"))
// Do not show for shell commands executed by user
props.message.modelID
}
>
<box
paddingLeft={2}
paddingLeft={inProgress() ? 2 : 3}
marginTop={1}
flexDirection="row"
gap={1}
border={["left"]}
border={inProgress() ? ["left"] : []}
customBorderChars={SplitBorder.customBorderChars}
borderColor={theme.backgroundElement}
>
<text fg={local.agent.color(props.message.mode)}>
{Locale.titlecase(props.message.mode)}
</text>
<Shimmer text={`${props.message.modelID}`} color={theme.text} />
</box>
</Show>
<Show
when={
props.message.time.completed &&
props.parts.some((item) => item.type === "step-finish" && item.reason !== "tool-calls")
}
>
<box paddingLeft={3}>
<text marginTop={1}>
<span style={{ fg: local.agent.color(props.message.mode) }}>
{Locale.titlecase(props.message.mode)}
</span>{" "}
<span style={{ fg: theme.textMuted }}>{props.message.modelID}</span>
</text>
{inProgress() ? (
<Shimmer text={`${props.message.modelID}`} color={theme.text} />
) : (
<text fg={theme.textMuted}>{props.message.modelID}</text>
)}
</box>
</Show>
</>
Expand Down