Skip to content

Conversation

Shashankss1205
Copy link
Contributor

@Shashankss1205 Shashankss1205 commented Mar 2, 2024

Resolves #1433 .

Description

This pull request adds native C implementation for
@stdlib/math/base/special/max for issue #1433 .

What is the purpose of this pull request?
Native C implementation of max function
This pull request:

  • a
  • b
  • c

Related Issues

Does this pull request have any related issues?

This pull request:

  • resolves #
  • fixes #

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes, once done this PR can be reviewed again.

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 3, 2024
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more changes and this be good to merge.

@Pranavchiku Pranavchiku changed the title feat: Add C implementation for @stdlib/math/base/special/max feat: Add C implementation for @stdlib/math/base/special/max Mar 3, 2024
Signed-off-by: Shashank Shekhar Singh <[email protected]>
Signed-off-by: Shashank Shekhar Singh <[email protected]>
Signed-off-by: Shashank Shekhar Singh <[email protected]>
Signed-off-by: Shashank Shekhar Singh <[email protected]>
@Planeshifter Planeshifter changed the title feat: Add C implementation for @stdlib/math/base/special/max feat: dd C implementation for math/base/special/max Mar 3, 2024
@Planeshifter Planeshifter changed the title feat: dd C implementation for math/base/special/max feat: Add C implementation for math/base/special/max Mar 3, 2024
@Planeshifter Planeshifter changed the title feat: Add C implementation for math/base/special/max feat: add C implementation for math/base/special/max Mar 3, 2024
@Shashankss1205
Copy link
Contributor Author

please close the PR if the issue has been resolved @Pranavchiku .

Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done, minor changes and this will be ready.

@Shashankss1205
Copy link
Contributor Author

Please take a look at this once @Pranavchiku . Sorry for the extraneous commits, I will try to keep them clean from the next PR's

@Shashankss1205
Copy link
Contributor Author

Please take a look at this once @Pranavchiku @Planeshifter.

Sorry for the extraneous commits, I will try to keep them clean from the next PR's I am just a beginner in open source.

Copy link
Member

@Planeshifter Planeshifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will merge once CI checks have cleared.

Thank you!

@Planeshifter Planeshifter merged commit 6831521 into stdlib-js:develop Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Needs Changes Pull request which needs changes before being merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/max

3 participants