Skip to content

feat: add C implementation for math/base/special/maxabs #1671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 11, 2024
Merged

feat: add C implementation for math/base/special/maxabs #1671

merged 15 commits into from
Mar 11, 2024

Conversation

Shashankss1205
Copy link
Contributor

@Shashankss1205 Shashankss1205 commented Mar 3, 2024 •
edited by kgryte
Loading

Resolves #1460 .

Description

What is the purpose of this pull request?

This pull request adds a C implementation for @stdlib/math/base/special/maxabs.

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Planeshifter Planeshifter changed the title feat: add C implementation for @stdlib/math/base/special/maxabs feat: add C implementation for math/base/special/maxabs Mar 3, 2024
@Pranavchiku Pranavchiku mentioned this pull request Mar 4, 2024
Closed
3 tasks
@kgryte kgryte mentioned this pull request Mar 4, 2024
Closed
1 task
Pranavchiku
Pranavchiku approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good, thanks @Shashankss1205 !

@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. Ready To Merge A pull request which is ready to be merged. Math Issue or pull request specific to math functionality. labels Mar 4, 2024
kgryte
kgryte reviewed Mar 4, 2024
View reviewed changes
kgryte
kgryte requested changes Mar 4, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @Shashankss1205. Left a few comments. This PR is blocked until #1459 is merged, given that it is a dependency of this implementation.

@kgryte kgryte added status: Blocked Issue or pull request which is currently blocked. Needs Changes Pull request which needs changes before being merged. and removed Ready To Merge A pull request which is ready to be merged. labels Mar 4, 2024
@Shashankss1205
Copy link
Contributor Author

Thanks for working on this @Shashankss1205. Left a few comments. This PR is blocked until #1459 is merged, given that it is a dependency of this implementation.

I have committed the changes. Please take a look at it and inform if there are any changes that are needed. @kgryte

@Planeshifter Planeshifter removed the status: Blocked Issue or pull request which is currently blocked. label Mar 10, 2024
@Planeshifter
Copy link
Member

@Shashankss1205 Now that #1459 is merged, would you please either merge in the latest changes from develop or rebase your PR branch so that CI will pass? Otherwise, I only found that a bunch of the C files are still missing trailing newlines. Once resolved, this PR should be ready to merge. Thank you very much!

@Shashankss1205
Copy link
Contributor Author

Now can You please review the PR @Planeshifter . I have made the corresponding changes.

Pranavchiku
Pranavchiku approved these changes Mar 10, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Shashankss1205 !

@Pranavchiku Pranavchiku added Ready To Merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 10, 2024
@Shashankss1205
Copy link
Contributor Author

LGTM. Thanks @Shashankss1205 !

Thank You!! Looking forward to working more here.

@Planeshifter Planeshifter merged commit fa68dfe into stdlib-js:develop Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kgryte kgryte kgryte requested changes

@Planeshifter Planeshifter Planeshifter approved these changes

+1 more reviewer

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Ready To Merge A pull request which is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/maxabs

4 participants

@Shashankss1205 @Planeshifter @kgryte @Pranavchiku