Use unique_ptr #22
Use unique_ptr #22
Conversation
|
This should fix a memory leak where a new thread is allocated every cycle |
src/zed_wrapper_node.cpp
Outdated
| sl::zed::Camera *zed; | ||
| std::unique_ptr<sl::zed::Camera> zed; | ||
| if (argc == 2) { | ||
| zed = new sl::zed::Camera(argv[1]); // Argument "svo_file" in launch file |
There was a problem hiding this comment.
This line doesn't pass the compilation process.
There was a problem hiding this comment.
What error does it give? I'm afraid I don't have access to a suitable compiler on my platform, and access to my embedded target is intermittent. Thanks for testing this for me.
There was a problem hiding this comment.
It's 21:40pm for me, so I don't have the error log with me, but I'll tell you tomorrow! However, I'm not used to std::unique_ptr, but don't we need to use std::move() to set the pointed object?
There was a problem hiding this comment.
Great, thanks! I won't be able to try things myself till then anyway.
I misread which line your comment was on. I think I see the fix.
`operator=` only works when the value is a `std::unique_ptr`. In C++ 14, this would be fixed by writing:
zed.reset(new sl::zed::Camera(static_cast<sl::zed::ZEDResolution_mode> (resolution), rate));
as
zed = std::make_unique<sl::zed::Camera>(static_cast<sl::zed::ZEDResolution_mode> (resolution), rate);
3 participants
No description provided.