-
Notifications
You must be signed in to change notification settings - Fork 406
Feat threading #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat threading #244
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
5f8ae64
Code refactoring
Myzhar 5d141ff
Replaced boost::thread with std::thread
Myzhar 5d11dd5
Added thread for Pointcloud publishing
Myzhar ed424ac
Fixes to Pointcloud thread...
Myzhar 1b16546
Pointcloud publishing improved
Myzhar f39e7f0
Replaced boost::shared_ptr with std::shared_ptr
Myzhar a46fefa
Removed usused stopWatch dependency
Myzhar 55d13f0
Changed default FPS
Myzhar 2be9ac5
Update README.md
Myzhar eeb8a54
Merge remote-tracking branch 'origin/master' into feat_threading
Myzhar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,7 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. | |
| <arg name="serial_number" default="0" /> | ||
| <arg name="verbose" default="true" /> | ||
| <arg name="resolution" default="2" /> <!--0=RESOLUTION_HD2K, 1=RESOLUTION_HD1080, 2=RESOLUTION_HD720, 3=RESOLUTION_VGA --> | ||
| <arg name="frame_rate" default="30" /> | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think 30 fps is a better default value, 60 is just too much data to process |
||
| <arg name="frame_rate" default="60" /> | ||
| <!-- RESOLUTION_HD2K -> 2208*1242, available framerates: 15 fps. | ||
| RESOLUTION_HD1080 -> 1920*1080, available framerates: 15, 30 fps. | ||
| RESOLUTION_HD720 -> 1280*720, available framerates: 15, 30, 60 fps. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you forgot to push this file. However, arguably I'd put it in sl_tools.cpp, also do we actually need a custom stopwatch? There is already a macro in the ZED SDK (
INIT_TIMER,STOP_TIMER(str))