Review Kasper

.changeset/sour-colts-retire.md

@@ -0,0 +1,5 @@
+---
+'@storybook/addon-mcp': patch
+---
+
+Handle GET responses in the MCP server

.github/actions/setup-node-and-install/action.yml

@@ -1,23 +1,32 @@
 name: 'Setup Node.js and Dependencies'
-description: 'Sets up Node.js, caches and installs dependencies'
+description: 'Sets up Node.js, caches, installs dependencies and turbo cache'
+
+inputs:
+  install-offline:
+    description: 'Install offline for speed?'
+    required: false
+    default: 'false'
 
 runs:
   using: 'composite'
   steps:
-    - name: Setup Node.js
-      uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
-      with:
-        node-version-file: '.nvmrc'
-
     - name: Install pnpm
       uses: pnpm/action-setup@41ff72655975bd51cab0327fa583b6e92b6d3061 # v4.2.0
 
-    - name: Setup Node.js
+    - name: Use Node.js 24
       uses: actions/setup-node@2028fbc5c25fe9cf00d9f06a71cc4710d4507903 # v6.0.0
       with:
-        node-version: 24
-        cache: 'pnpm'
+        cache: pnpm
+
+    - name: Cache for Turbo
+      uses: rharkor/[email protected]
 
     - name: Install dependencies
+      if: ${{ inputs.install-offline != 'true' }}
       shell: bash
       run: pnpm install --frozen-lockfile --prefer-offline --ignore-scripts
+
+    - name: Install dependencies
+      if: ${{ inputs.install-offline == 'true' }}
+      shell: bash
+      run: pnpm install --frozen-lockfile --offline --ignore-scripts

.github/workflows/check.yml

@@ -11,8 +11,8 @@ permissions:
   id-token: write # used to upload artifacts to codecov
 
 jobs:
-  build-mcp:
-    name: Build @storybook/mcp
+  build:
+    name: Build
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -24,22 +24,7 @@ jobs:
         uses: ./.github/actions/setup-node-and-install
 
       - name: Build
-        run: pnpm build --env-mode=loose --filter @storybook/mcp
-
-  build-addon-mcp:
-    name: Build @storybook/addon-mcp
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-        with:
-          fetch-depth: 2 # see https://docs.codecov.com/docs/environment-specific-requirements#github-actions
-
-      - name: Setup Node.js and Install Dependencies
-        uses: ./.github/actions/setup-node-and-install
-
-      - name: Build
-        run: pnpm build --env-mode=loose --filter @storybook/addon-mcp
+        run: pnpm turbo run build
 
   build-storybook:
     name: Build internal Storybook
@@ -52,70 +37,42 @@ jobs:
         uses: ./.github/actions/setup-node-and-install
 
       - name: Build
-        run: pnpm build-storybook
+        run: pnpm turbo run build-storybook
 
-  test-mcp:
-    name: Test @storybook/mcp
+  test:
+    name: Test
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+        with:
+          fetch-depth: 2 # see https://docs.codecov.com/docs/environment-specific-requirements#github-actions
 
       - name: Setup Node.js and Install Dependencies
         uses: ./.github/actions/setup-node-and-install
 
       - name: Run tests with coverage
-        run: pnpm --filter @storybook/mcp test run --coverage --reporter=default --reporter=junit --outputFile=test-report.junit.xml
+        run: pnpm turbo run test:ci
 
-      - name: Upload test and coverage artifact
-        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
-        if: always()
+      - name: Upload coverage to Codecov
+        uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1
         with:
-          name: test-mcp
-          path: |
-            packages/mcp/coverage/
-            packages/mcp/test-report.junit.xml
-
-  test-addon-mcp:
-    name: Test @storybook/addon-mcp
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-
-      - name: Setup Node.js and Install Dependencies
-        uses: ./.github/actions/setup-node-and-install
-
-      - name: Build @storybook/mcp (dependency)
-        run: pnpm build --filter @storybook/mcp
-
-      - name: Run tests with coverage
-        run: pnpm --filter @storybook/addon-mcp test run --coverage --reporter=default --reporter=junit --outputFile=test-report.junit.xml
+          use_oidc: true
+          fail_ci_if_error: true
+          files: |
+            coverage/lcov.info
 
-      - name: Upload test and coverage artifact
-        uses: actions/upload-artifact@330a01c490aca151604b8cf639adc76d48f6c5d4 # v5.0.0
+      - name: Upload test results to Codecov
+        uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
         if: always()
         with:
-          name: test-addon-mcp
-          path: |
-            packages/addon-mcp/coverage/
-            packages/addon-mcp/test-report.junit.xml
-
-  typecheck-mcp:
-    name: Type check @storybook/mcp
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-
-      - name: Setup Node.js and Install Dependencies
-        uses: ./.github/actions/setup-node-and-install
-
-      - name: Run type checking
-        run: pnpm --filter @storybook/mcp typecheck
+          use_oidc: true
+          fail_ci_if_error: true
+          files: |
+            test-report.junit.xml
 
-  typecheck-addon-mcp:
-    name: Type check @storybook/addon-mcp
+  typecheck:
+    name: Type check
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
@@ -124,11 +81,8 @@ jobs:
       - name: Setup Node.js and Install Dependencies
         uses: ./.github/actions/setup-node-and-install
 
-      - name: Build @storybook/mcp (dependency)
-        run: pnpm build --filter @storybook/mcp
-
       - name: Run type checking
-        run: pnpm --filter @storybook/addon-mcp typecheck
+        run: pnpm turbo run typecheck
 
   publint:
     name: Publint
@@ -141,7 +95,7 @@ jobs:
         uses: ./.github/actions/setup-node-and-install
 
       - name: Run linting
-        run: pnpm publint
+        run: pnpm turbo run publint
 
   lint:
     name: Lint
@@ -154,7 +108,7 @@ jobs:
         uses: ./.github/actions/setup-node-and-install
 
       - name: Run linting
-        run: pnpm lint
+        run: pnpm turbo run lint:ci
 
   format-check:
     name: Check formatting
@@ -167,44 +121,4 @@ jobs:
         uses: ./.github/actions/setup-node-and-install
 
       - name: Check formatting
-        run: pnpm format --check
-
-  collect-coverage:
-    name: Collect coverage and test results
-    runs-on: ubuntu-latest
-    needs: [test-mcp, test-addon-mcp]
-    if: always()
-    steps:
-      - name: Checkout
-        uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
-        with:
-          fetch-depth: 2 # see https://docs.codecov.com/docs/environment-specific-requirements#github-actions
-
-      - name: Download @storybook/mcp coverage
-        uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
-        with:
-          name: test-mcp
-          path: packages/mcp/
-
-      - name: Download @storybook/addon-mcp coverage
-        uses: actions/download-artifact@018cc2cf5baa6db3ef3c5f8a56943fffe632ef53 # v6.0.0
-        with:
-          name: test-addon-mcp
-          path: packages/addon-mcp/
-
-      - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@5a1091511ad55cbe89839c7260b706298ca349f7 # v5.5.1
-        with:
-          use_oidc: true
-          fail_ci_if_error: true
-          files: |
-            packages/mcp/coverage/lcov.info
-            packages/addon-mcp/coverage/lcov.info
-      - name: Upload test results to Codecov
-        uses: codecov/test-results-action@47f89e9acb64b76debcd5ea40642d25a4adced9f # v1.1.1
-        with:
-          use_oidc: true
-          fail_ci_if_error: true
-          files: |
-            packages/mcp/test-report.junit.xml
-            packages/addon-mcp/test-report.junit.xml
+        run: pnpm turbo run format:check

apps/internal-storybook/package.json

@@ -6,17 +6,18 @@
 	"scripts": {
 		"build-storybook": "storybook build",
 		"storybook": "storybook dev --port 6006 --loglevel debug",
-		"typecheck": "tsc --noEmit"
+		"typecheck": "tsc"
 	},
 	"devDependencies": {
 		"@storybook/addon-docs": "catalog:",
 		"@storybook/addon-mcp": "workspace:*",
 		"@storybook/react-vite": "catalog:",
 		"@types/react": "^18.2.65",
 		"@types/react-dom": "^18.2.21",
-		"@vitejs/plugin-react": "^4.7.0",
+		"@vitejs/plugin-react": "^5.1.1",
 		"react": "^18.2.0",
 		"react-dom": "^18.2.0",
-		"storybook": "catalog:"
+		"storybook": "catalog:",
+		"vite": "catalog:"
 	}
 }

apps/internal-storybook/tsconfig.json

@@ -1,21 +1,7 @@
 {
+	"extends": "../../tsconfig.json",
 	"compilerOptions": {
-		"esModuleInterop": true,
-		"skipLibCheck": true,
-		"target": "es2023", // Node 20 according to https://github.com/microsoft/TypeScript/wiki/Node-Target-Mapping#node-20
-		"allowJs": true,
-		"resolveJsonModule": true,
-		"moduleDetection": "force",
-		"moduleResolution": "bundler",
-		"module": "esnext",
-		"jsx": "react",
-		"isolatedModules": true,
-		"verbatimModuleSyntax": true,
-		"strict": true,
-		"noUncheckedIndexedAccess": true,
-		"noImplicitOverride": true,
-		"noImplicitAny": true,
-		"lib": ["esnext", "dom", "dom.iterable"]
+		"jsx": "react"
 	},
-	"include": ["stories/**/*"]
+	"include": ["stories/**/*", "**/*.ts"]
 }

apps/internal-storybook/vite.config.ts

@@ -1,7 +1,6 @@
 import { defineConfig } from 'vite';
 import react from '@vitejs/plugin-react';
 
-// https://vitejs.dev/config/
 export default defineConfig({
 	plugins: [react()],
 });

package.json

@@ -14,28 +14,41 @@
 		"changeset": "changeset",
 		"dev": "turbo run dev",
 		"format": "prettier --write .",
+		"format:check": "prettier --check .",
 		"inspect": "pnpm run --filter @storybook/addon-mcp inspect",
 		"lint": "oxlint --type-aware",
-		"check-everything": "pnpm run format --check && pnpm run lint && pnpm run publint && pnpm run build && pnpm run build-storybook && pnpm run typecheck && pnpm run test -- run",
+		"lint:ci": "oxlint --format github --type-aware",
+		"check": "turbo run build build-storybook format lint publint typecheck test --continue",
+		"check:watch": "turbo watch build build-storybook format lint publint typecheck test --continue --experimental-write-cache",
 		"publint": "turbo run publint",
 		"release": "turbo run build && pnpm changeset publish",
-		"storybook": "turbo run storybook",
-		"test": "turbo run test",
-		"typecheck": "turbo run typecheck"
+		"test": "vitest run",
+		"test:ci": "vitest run --coverage --reporter=default --reporter=github-actions --reporter=junit --outputFile=test-report.junit.xml",
+		"typecheck": "tsc",
+		"turbo": "turbo",
+		"turbo:test": "turbo run test",
+		"turbo:typecheck": "turbo run typecheck"
 	},
 	"devDependencies": {
 		"@changesets/changelog-github": "^0.5.1",
 		"@changesets/cli": "^2.29.6",
 		"@codecov/rollup-plugin": "^1.9.1",
 		"@codecov/vite-plugin": "^1.9.1",
-		"@modelcontextprotocol/inspector": "^0.16.5",
+		"@modelcontextprotocol/inspector": "^0.17.2",
+		"@storybook/addon-mcp": "workspace:",
+		"@storybook/mcp": "workspace:",
+		"@types/node": "20.19.0",
+		"@vitest/coverage-v8": "^4.0.8",
 		"oxlint": "^1.25.0",
 		"oxlint-tsgolint": "^0.4.0",
 		"pkg-pr-new": "^0.0.57",
 		"prettier": "^3.6.2",
-		"tsdown": "catalog:",
-		"turbo": "^2.3.5",
-		"vitest": "catalog:"
+		"publint": "^0.3.15",
+		"tsdown": "^0.16.4",
+		"turbo": "^2.6.1",
+		"vite-tsconfig-paths": "^5.1.4",
+		"vite": "catalog:",
+		"vitest": "^4.0.8"
 	},
 	"packageManager": "[email protected]+sha512.c9fc7236e92adf5c8af42fd5bf1612df99c2ceb62f27047032f4720b33f8eacdde311865e91c411f2774f618d82f320808ecb51718bfa82c060c4ba7c76a32b8"
 }

packages/addon-mcp/package.json

@@ -26,12 +26,12 @@
 	],
 	"scripts": {
 		"prebuild": "node -e \"fs.rmSync('./dist', { recursive: true, force: true })\"",
-		"build": "tsdown --config ../../tsdown.config.ts",
+		"build": "tsdown",
 		"dev": "pnpm run build -- --watch",
 		"inspect": "mcp-inspector --config ../../.mcp.inspect.json --server storybook-addon-mcp",
 		"publint": "publint",
 		"test": "vitest",
-		"typecheck": "tsc --noEmit"
+		"typecheck": "tsc"
 	},
 	"dependencies": {
 		"@storybook/mcp": "workspace:*",
@@ -41,15 +41,8 @@
 		"valibot": "catalog:"
 	},
 	"devDependencies": {
-		"@types/node": "catalog:",
-		"@vitest/coverage-v8": "catalog:",
-		"publint": "catalog:",
 		"storybook": "catalog:",
-		"ts-dedent": "^2.2.0",
-		"tsdown": "catalog:",
-		"typescript": "catalog:",
-		"vite": "^7.0.5",
-		"vitest": "catalog:"
+		"ts-dedent": "^2.2.0"
 	},
 	"peerDependencies": {
 		"storybook": "^9.1.16 || ^10.0.0 || ^10.1.0-0 || ^10.2.0-0 || ^10.3.0-0 || ^10.4.0-0"