Review Kasper #70

kasperpeulen · 2025-11-12T15:25:23Z

No description provided.

changeset-bot · 2025-11-12T15:25:27Z

🦋 Changeset detected

Latest commit: b59aaae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@storybook/addon-mcp	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-11-13T15:33:04Z

npm i https://pkg.pr.new/@storybook/addon-mcp@70

npm i https://pkg.pr.new/@storybook/mcp@70

commit: b59aaae

codecov · 2025-11-13T15:33:10Z

Codecov Report

❌ Patch coverage is 11.90476% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.10%. Comparing base (28d675e) to head (b59aaae).
⚠️ Report is 1 commits behind head on next.
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...g-rsuite/expected/src/components/FlightBooking.tsx	0.00%	33 Missing ⚠️
packages/addon-mcp/src/preset.ts	0.00%	4 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             next      #70       +/-   ##
===========================================
- Coverage   79.15%   39.10%   -40.05%     
===========================================
  Files          15       23        +8     
  Lines         331      693      +362     
  Branches       98      172       +74     
===========================================
+ Hits          262      271        +9     
- Misses         38      391      +353     
  Partials       31       31

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

codecov · 2025-11-13T15:34:18Z

Bundle Report

Changes will increase total bundle size by 37.74kB (100.0%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name	Size	Change
@storybook/mcp-esm*	20.17kB	20.17kB (100%) ⬆️⚠️
@storybook/addon-mcp-esm*	17.57kB	17.57kB (100%) ⬆️⚠️

ℹ️ *Bundle size includes cached data from a previous commit

.github/workflows/check.yml

apps/internal-storybook/package.json

packages/addon-mcp/src/preset.ts

packages/addon-mcp/package.json

packages/mcp/src/index.ts

packages/mcp/package.json

Co-authored-by: Jeppe Reinhold <[email protected]>

This reverts commit c63f9ee.

This reverts commit d647a91.

This reverts commit 766462e.

.github/actions/setup-node-and-install/action.yml

.github/workflows/check.yml

package.json

JReinhold · 2025-11-17T12:47:13Z

@copilot this PR makes a lot of changes to the repository's internal scripts, both at the root level and in the packages. can you inspect the changes and update the readme files and copilot instructions accordingly?

Copilot · 2025-11-17T12:47:22Z

@JReinhold I've opened a new pull request, #76, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: JReinhold <[email protected]>

Update documentation for script refactoring changes

# Conflicts: # package.json # packages/mcp/package.json # pnpm-lock.yaml # pnpm-workspace.yaml

Copilot

Pull Request Overview

This PR consolidates the monorepo's testing and build infrastructure by centralizing Vitest configuration at the root level, improving CI workflows, and standardizing tooling across packages. The changes modernize the development workflow with better Turbo integration and remove redundant configurations.

Centralized Vitest configuration with workspace projects instead of per-package configs
Consolidated CI jobs to reduce duplication and improve efficiency
Standardized TypeScript configuration across packages by extending a root tsconfig
Updated documentation to reflect the new testing and development workflows

Reviewed Changes

Copilot reviewed 33 out of 36 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
vitest.config.ts	New root-level Vitest configuration with workspace projects and centralized coverage settings
vitest-shared.config.ts	Removed - replaced by root configuration
turbo.json	Added TUI mode and task configurations for root-level commands
packages/*/vitest.config.ts	Updated to use mergeConfig pattern with root configuration
packages/*/tsconfig.json	Simplified to extend root tsconfig instead of duplicating settings
packages/*/package.json	Updated test commands to run from monorepo root
.github/workflows/check.yml	Consolidated separate package jobs into unified build/test/typecheck jobs
README.md	Updated documentation for new testing and development workflows
package.json	Added new test and check commands for centralized execution

Copilot · 2025-11-18T12:11:46Z

packages/addon-mcp/src/preset.ts

+	// There is error handling here. The can make the whole storybook app crash with.
+	// ValiError: Invalid type: Expected boolean but received "false"


Corrected spelling of 'can' to 'can' and completed the sentence. The comment should read: "There is no error handling here. This can make the whole storybook app crash with:"

Copilot · 2025-11-18T12:11:46Z

packages/addon-mcp/src/preset.ts

+	app!.use('/mcp', (req, res) => {
+		if (req.method === 'GET' && req.headers['accept']?.includes('text/html')) {


The route handler changed from app.get() to app.use() with a manual method check. This is less idiomatic and could match other HTTP methods before checking. Consider using app.get() for the HTML response and keeping the POST handler separate, or add an early return/next() call for non-GET requests.

Suggested change

app!.use('/mcp', (req, res) => {

if (req.method === 'GET' && req.headers['accept']?.includes('text/html')) {

app!.get('/mcp', (req, res) => {

if (req.headers['accept']?.includes('text/html')) {

* enter prereelase mode on next branch * Handle HTML in a separate file (#56) * extract human-readable /mcp to maintainable html file * upgrade tsdown, remove json treeshaking workaround * add changeset * fix tsdown types * add changeset release branches to checks * commit releases with gh api. see https://github.com/changesets/action#inputs * Version Packages (next) (#57) Co-authored-by: storybook-app-bot[bot] <175111413+storybook-app-bot[bot]@users.noreply.github.com> * Replace Storybook canary versions with 10.1.0 prereleases (#59) * upgrade to storybook 10.1.0-alpha.2 * changesets * Version Packages (next) (#60) Co-authored-by: storybook-app-bot[bot] <175111413+storybook-app-bot[bot]@users.noreply.github.com> * Rename "examples" to "stories" in component manifest format (#61) * Initial plan * Rename "examples" to "stories" in component manifest format - Updated type definitions in types.ts files to rename Example to Story - Updated format-manifest.ts to use story terminology (story, story_name, story_description, story_code) - Updated all fixture JSON files to use "stories" instead of "examples" - Updated test files and descriptions to use "stories" terminology - Updated test snapshots to reflect the new XML output format - All tests passing, build and typecheck successful --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: Jeppe Reinhold <[email protected]> * Support name in manifest errors (#55) * add name to manifest errors * add fixtures with errors * add changeset * improve test reports in ci * update fixtures to use stories instead of examples * more example -> story renaming * Improve code quality and development setup (#64) * replace prettier with oxfmt * add oxlint for linting * update actions using npx actions-up * add publint * fix types * add check-everything script * add build-storybook to check all * split GH Workflows * explain lint disables * Version Packages (next) (#63) Co-authored-by: storybook-app-bot[bot] <175111413+storybook-app-bot[bot]@users.noreply.github.com> * Replace oxfmt with Prettier (#68) * replace oxfmt with prettier * typo * Update to the latest SB alpha so the internal storybook version works with the server (#71) Co-authored-by: Jeppe Reinhold <[email protected]> * Revert Embed demo image from storybook.js.org#21 (#75) * Evals (#69) * add initial eval setup * well, a lot happened here... * add clack * Add interactive prompts and styled output to eval CLI (#65) * Initial plan * Add interactive prompts and prettier output to eval CLI Co-authored-by: JReinhold <[email protected]> * Use tasks API for parallel evaluation steps Co-authored-by: JReinhold <[email protected]> * Apply oxfmt formatting to eval.ts --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JReinhold <[email protected]> * improve terminal experience * save environment * improve terminal experience * only allow one eval at a time * add support for custom context * format * add support for eval hooks, add log about how to rerun experiments * prompt to start storybook at the end of the evaluation * add message about getting into the experiment * improve experiment dir name * take screenshots of failed stories too * cleanup * improve reshaped stories, improve test+a11y summary, improve mcp server config arg * support --[no-]storybook flag * collect experiment description and branch name * save result summary to google sheets * improve plain prompt * prompt for google sheets upload * fix google sheets upload * support "Storybook MCP" context, which starts up the docs-only @storybook/mcp server with a given component manifest * Add basic Radix eval (#66) * Add Radix eval * Add Rsuite eval (#67) --------- Co-authored-by: Jeppe Reinhold <[email protected]> * format * fix typechecking * add reshaped component manifest * add conversation-viewer.html with approximate token count * cleanup * add documentation, fixups * format * fix stories not having imports anymore * fix plain and radix experiments * experiments will have unique package names * more eval test fixing * more story fixes * fix typecheck and lint summary * improve conversation viewer * simplify viewer content * simplify viewer content * result visualisations is via storybook * upload to chromatic * update google sheet row order * add Chromatic link to CLI log * add note about public results * remove description arg from evals * Evals: Add Radix UI website prompt (#74) --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: JReinhold <[email protected]> Co-authored-by: Michael Shilman <[email protected]> * Review Kasper (#70) * Start review * Fix * More comments * Fix config files and restructure * Resolve conflicts * Fix github actions * Fix coverage * Fix type error * Fix * Fix * Dedupe * Update packages/mcp/src/index.ts Co-authored-by: Jeppe Reinhold <[email protected]> * Update .github/workflows/check.yml Co-authored-by: Jeppe Reinhold <[email protected]> * Update .github/workflows/check.yml Co-authored-by: Jeppe Reinhold <[email protected]> * Improve get/post handling * Dedupe vite * lock file * test perf of check-everything in CI * rename * rename * Add turbo caching * check cache invalidation * refactor * refactor * refactor * refactor * Use node version file * description * refactor * rollback * use turbo for artifacts * install node * optimize * install offline for faster symlinking * optimize * Check ci * Only upload test results on failure * Check github reporter * Fix command * Fix test * Remove check everything * test corepack enable * test corepack enable * test corepack enable * fix * Check if this is faster * Check if this is faster * no cache * rollback * Change nothing * Fix prettier * Modify changeset for MCP server GET responses Updated the changeset to handle GET responses in the MCP server. * Prettier * use docker * debug * use node 24 * Try own caching * Prune it * Don't format pnpm lock * Fix * again * use composite * change * Revert "change" This reverts commit 8031a63. * Revert "use composite" This reverts commit 7f26a54. * Revert "again" This reverts commit 7fdccdf. * Revert "Fix" This reverts commit f4dd004. * Revert "Don't format pnpm lock" This reverts commit c11c4ec. * Revert "Prune it" This reverts commit 1009ad5. * Revert "Try own caching" This reverts commit 82eb804. * Revert "use node 24" This reverts commit c63f9ee. * Revert "debug" This reverts commit d647a91. * Revert "use docker" This reverts commit 766462e. * Address feedback * Initial plan * Update README and Copilot instructions for script changes Co-authored-by: JReinhold <[email protected]> * Address feedback * Make it loose * Watch storybook by default * Fix command * Fix * Add pnpm to ignore * Fix dev command * Cleanup * get CI green --------- Co-authored-by: Jeppe Reinhold <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JReinhold <[email protected]> * Make `get-component-documentation` tool only accept a single component ID instead of multiple (#79) * cleanup * get-component-documentation only accepts a single component id * Fix evals (#81) * cleanup * get-component-documentation only accepts a single component id * fix versions * use vitest cli instead of node for evals * prefix experiment scripts so they are not picked up by turborepo * Add toolset property to telemetry payloads in addon-mcp (#78) * Initial plan * Add toolset property to all telemetry payloads in addon-mcp Co-authored-by: JReinhold <[email protected]> * add changeset --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: JReinhold <[email protected]> Co-authored-by: Jeppe Reinhold <[email protected]> Co-authored-by: Jeppe Reinhold <[email protected]> * remove source API and use the request instead (#54) * remove source API and use the request instead * cleanup * add changesets * add path argument to manifestProvider * cleanup * update changeset * fix serve.ts * cleanup * Fix internal stdio-based MCP server (#85) * allow undefined requests when using custom manifestProvider * changeset * add tests for internal stdio transport * cleanup * Add end-to-end tests and improve unit test quality (#84) * add e2e tests * improve e2e scripting * add tests for mcp index * add preset tests * add telemetry tests * simplify tool test mocks * simplify mcp-handler tests, improve disableTelemetry handling * add tests for manifest availability * exclude evals from coverage * cleanup * changeset * fix preset registering handlers instead of middlewares * update tests to match changes in base branch * cleanup * await sb process kill * globally mock storybook deps * clean lock file * Output in markdown instead of XML (#86) * add e2e tests * improve e2e scripting * add tests for mcp index * add preset tests * add telemetry tests * simplify tool test mocks * simplify mcp-handler tests, improve disableTelemetry handling * add tests for manifest availability * exclude evals from coverage * cleanup * changeset * fix preset registering handlers instead of middlewares * update tests to match changes in base branch * cleanup * await sb process kill * refactor formatter, splitting into markdown and xml, configurable, defaulting to markdown * globally mock storybook deps * clean lock file * fix context arg * fix tests * fix types * "Examples" -> "Stories", simplify tests * simplify tests and types * simplify * use ts-like prop type docs format * add script to clean experiments * add changeset * exit pre mode (#88) * Update reshaped flight booking eval (#87) * Update reshaped flight booking eval * format --------- Co-authored-by: Jeppe Reinhold <[email protected]> Co-authored-by: Jeppe Reinhold <[email protected]> * Version Packages (#80) Co-authored-by: storybook-app-bot[bot] <175111413+storybook-app-bot[bot]@users.noreply.github.com> --------- Co-authored-by: storybook-app-bot[bot] <175111413+storybook-app-bot[bot]@users.noreply.github.com> Co-authored-by: Copilot <[email protected]> Co-authored-by: Tom Coleman <[email protected]> Co-authored-by: Michael Shilman <[email protected]> Co-authored-by: JReinhold <[email protected]> Co-authored-by: Kasper Peulen <[email protected]>

kasperpeulen added 3 commits November 12, 2025 14:26

Start review

691c12e

Fix

96656c8

More comments

fad2366

Fix config files and restructure

99511ca

kasperpeulen added the bug Something isn't working label Nov 13, 2025

kasperpeulen added 2 commits November 13, 2025 16:32

Merge remote-tracking branch 'origin/next' into kasper/review

4b9c00d

Resolve conflicts

89e8cad

kasperpeulen added 5 commits November 13, 2025 16:35

Fix github actions

7e7bd1c

Fix coverage

6654fa9

Fix type error

b13a87c

Fix

61dca61

Fix

f9ed2bd

kasperpeulen requested a review from JReinhold November 13, 2025 16:01

Dedupe

12bca9f

JReinhold requested changes Nov 14, 2025

View reviewed changes

kasperpeulen and others added 11 commits November 14, 2025 11:51

Update packages/mcp/src/index.ts

b2e0905

Co-authored-by: Jeppe Reinhold <[email protected]>

Update .github/workflows/check.yml

24e8e19

Co-authored-by: Jeppe Reinhold <[email protected]>

Update .github/workflows/check.yml

31b0f43

Co-authored-by: Jeppe Reinhold <[email protected]>

Improve get/post handling

9e79960

Merge remote-tracking branch 'origin/kasper/review' into kasper/review

b6aba7b

Dedupe vite

8a1c782

lock file

f81a14a

test perf of check-everything in CI

99a3c79

rename

b969454

rename

29e09c8

Add turbo caching

e18e272

kasperpeulen added 3 commits November 14, 2025 18:40

Revert "use node 24"

11fa125

This reverts commit c63f9ee.

Revert "debug"

74296ba

This reverts commit d647a91.

Revert "use docker"

177ea6a

This reverts commit 766462e.

JReinhold reviewed Nov 17, 2025

View reviewed changes

.github/actions/setup-node-and-install/action.yml Show resolved Hide resolved

.github/workflows/check.yml Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

Address feedback

2127776

Initial plan

889e682

Copilot AI mentioned this pull request Nov 17, 2025

Update documentation for script refactoring changes #76

Merged

Copilot AI and others added 9 commits November 17, 2025 12:53

Update README and Copilot instructions for script changes

e926395

Co-authored-by: JReinhold <[email protected]>

Address feedback

e123532

Merge remote-tracking branch 'origin/next' into kasper/review

90dfdfb

Make it loose

0034279

Watch storybook by default

09dfed6

Fix command

9a06f3a

Merge pull request #76 from storybookjs/copilot/sub-pr-70

c23cf72

Update documentation for script refactoring changes

Fix

8e0dd1f

Add pnpm to ignore

ffde8c8

JReinhold approved these changes Nov 17, 2025

View reviewed changes

kasperpeulen added 3 commits November 17, 2025 14:43

Fix dev command

94bfa31

Cleanup

6b76bef

Merge remote-tracking branch 'origin/next' into kasper/review

c531ddc

# Conflicts: # package.json # packages/mcp/package.json # pnpm-lock.yaml # pnpm-workspace.yaml

Copilot AI review requested due to automatic review settings November 18, 2025 12:09

Copilot AI reviewed Nov 18, 2025

View reviewed changes

get CI green

b59aaae

kasperpeulen merged commit cf4ef86 into next Nov 18, 2025
10 of 12 checks passed

kasperpeulen deleted the kasper/review branch November 18, 2025 12:19

storybook-app-bot bot mentioned this pull request Nov 18, 2025

Version Packages #80

Merged

JReinhold mentioned this pull request Nov 18, 2025

Fix evals #81

Merged

		// There is error handling here. The can make the whole storybook app crash with.
		// ValiError: Invalid type: Expected boolean but received "false"

		app!.use('/mcp', (req, res) => {
		if (req.method === 'GET' && req.headers['accept']?.includes('text/html')) {

Review Kasper #70

Review Kasper #70

Uh oh!

Conversation

kasperpeulen commented Nov 12, 2025

Uh oh!

changeset-bot bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codecov bot commented Nov 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JReinhold commented Nov 17, 2025

Uh oh!

Copilot AI commented Nov 17, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

changeset-bot bot commented Nov 12, 2025 •

edited

Loading

pkg-pr-new bot commented Nov 13, 2025 •

edited

Loading

codecov bot commented Nov 13, 2025 •

edited

Loading

codecov bot commented Nov 13, 2025 •

edited

Loading