Update reshaped flight booking eval

[shilman]

Latest prompt, stories, components.json

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4327f47

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR

Some errors occurred when validating the changesets config:
The package or glob expression "@storybook/mcp-eval*" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

[pkg-pr-new]

npm i https://pkg.pr.new/@storybook/addon-mcp@87

npm i https://pkg.pr.new/@storybook/mcp@87

commit: 4327f47

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.13%. Comparing base (09dad11) to head (4327f47).
⚠️ Report is 1 commits behind head on next.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             next      #87   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files          19       19           
  Lines         414      414           
  Branches      116      116           
=======================================
  Hits          369      369           
  Misses          6        6           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Copilot]

Pull Request Overview

This PR updates the flight booking evaluation with improved test infrastructure and data-testid requirements. The changes add specific test IDs to the prompt requirements, refactor the stories file to use a more robust element selection strategy, and update the components.json file with new import patterns and error messages.

Key Changes

• Added data-testid requirements to all interactive elements in the prompt
• Introduced looseGetInteractiveElements helper for flexible element selection in tests
• Updated story type annotations from implicit to explicit Story types
• Modified components.json with consolidated imports and updated error messages

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.

File	Description
prompt.md	Added data-testid requirements to each technical requirement
FlightBooking.stories.tsx	Added helper function for element selection, restructured stories with explicit types
components.json	Updated import statements to use consolidated exports, changed error message text

[Copilot]

Corrected grammar error: 'SHOULD have include' should be 'SHOULD include'

Suggested change

	8. Each element to select an airport in the pickers SHOULD have include both the shortcode and full airport name in its content and SHOULD have data-testid="airport-{SHORTCODE}" (e.g., "airport-MEL", "airport-LAX")
	8. Each element to select an airport in the pickers SHOULD include both the shortcode and full airport name in its content and SHOULD have data-testid="airport-{SHORTCODE}" (e.g., "airport-MEL", "airport-LAX")

[Copilot]

Missing verb: 'SHOULD the day' should be 'SHOULD have the day' or 'SHOULD show the day'

Suggested change

	11. Each date in the date selects SHOULD the day of month as its only content and SHOULD have data-testid="date-{DAY}" (e.g., "date-27", "date-15")
	11. Each date in the date selects SHOULD have the day of month as its only content and SHOULD have data-testid="date-{DAY}" (e.g., "date-27", "date-15")

[Copilot]

Pushing null as any to the interactive array appears to be a hack to ensure the array is never empty. This could cause runtime errors when accessing elements. Consider returning an empty array or throwing an error if no elements are found, or document why null is being added.

Suggested change

interactive.push(null as any);

[Copilot]

Redundant query: screen.queryAllByTestId(testId) is called twice - once at line 37 and again at line 42 in the candidates array. The second call is unnecessary since we already checked if byTestId has results.

Suggested change

...screen.queryAllByTestId(testId),