Fix display of large components #1237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add CSS to allow for oversized components to scroll in all directions. See [issue storybookjs#1225](storybookjs#1225 (comment)).
Codecov Report
@@ Coverage Diff @@
## master #1237 +/- ##
=======================================
Coverage 14.35% 14.35%
=======================================
Files 201 201
Lines 4612 4612
Branches 504 498 -6
=======================================
Hits 662 662
- Misses 3516 3518 +2
+ Partials 434 432 -2
Continue to review full report at Codecov.
|
ndelangen
reviewed
Jun 9, 2017
|
|
||
| export default function(storyFn) { | ||
| return <div style={style}>{storyFn()}</div>; | ||
| return <div style={style}><div style={innerStyle}>{storyFn()}</div></div>; |
Member
There was a problem hiding this comment.
I think adding another container defeats the purpose of the centered addon, I'll have to test.
Contributor
Author
There was a problem hiding this comment.
Were you able to test this? I'd be happy to try to improve the fix if this proves to have problems.
Member
|
It works wonders! Thanks you, you are awesome @su-narthur! Sorry it took so long to view and merge, totally my fault! |
ndelangen
approved these changes
Jul 7, 2017
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CSS to allow for oversized components to scroll in all directions. See issue #1225.
Issue: Overflowing portions of large components are inaccessible when using Centered plugin.
What I did
I added
overflow: autoto the outer wrapper andmargin: autoto a new inner wrapper.How to test
Create a component larger than your viewport and check that you can stroll both up and down to see the entire component.