-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
UI: Set color scheme to sync scrollbar color with user-selected theme #28666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Set color scheme to sync scrollbar color with user-selected theme #28666
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This pull request introduces the color-scheme property to synchronize scrollbar colors with the user-selected theme (light or dark).
- Tooltip.tsx: Added
colorSchemetoWrapperstyled component to adjust tooltip scrollbar color. - Layout.tsx: Added
colorSchemetoLayoutContainerstyled component for consistent scrollbar color with the theme.
These changes ensure a cohesive user experience by aligning scrollbar colors with the selected theme. Ensure cross-browser compatibility for the color-scheme property.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
|
View your CI Pipeline Execution ↗ for commit 1edccd0.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 51 | 51 | 0 |
| Self size | 31.73 MB | 31.72 MB | 🎉 -16 KB 🎉 |
| Dependency size | 17.43 MB | 17.43 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/ember
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 202 | 204 | 🚨 +2 🚨 |
| Self size | 28 KB | 28 KB | 🎉 -2 B 🎉 |
| Dependency size | 27.94 MB | 28.75 MB | 🚨 +810 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 52 | 52 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 49.16 MB | 49.15 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 217 | 217 | 0 |
| Self size | 582 KB | 582 KB | 0 B |
| Dependency size | 94.77 MB | 94.75 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 186 | 186 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 78.87 MB | 78.85 MB | 🎉 -16 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
UI: Set color scheme to sync scrollbar color with user-selected theme (cherry picked from commit 6b69631)
What I did
Use the
color-schemeproperty so that the scrollbar color adjusts according to the user's selected theme (light or dark).This property has been added to the layout component and the tooltip wrapper (as the tooltip is appended to the body using React portals).
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task --task sandbox --start-from auto --template react-vite/default-tsBefore:
After:
Note that light mode is not impacted:

Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>