Skip to content

UI: Fix Visual Focus Indicators aren't visible in high contrast mode #29239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
natainakata wants to merge 6 commits into from
Closed

UI: Fix Visual Focus Indicators aren't visible in high contrast mode #29239

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6756cfd
fix: high contrast mode support for action bar vfis
natainakata Sep 29, 2024
83662aa
fix: high contrast mode support for input
natainakata Sep 29, 2024
341b4fd
fix: high contrast mode support for boolean
natainakata Sep 29, 2024
56e246e
style: unified in outline after review.
natainakata Sep 29, 2024
04990d7
Merge branch 'next' into fix-vfi-high-contrast
natainakata Oct 1, 2024
c8bb483
chore: nested media queries
natainakata Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions code/core/src/components/components/ActionBar/ActionBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ export const ActionButton = styled.button<{ disabled: boolean }>(
boxShadow: `${theme.color.secondary} 0 -3px 0 0 inset`,
outline: '0 none',
},

'@media (forced-colors: active)': {
'&:focus': {
outline: '1px solid highlight',
},
},
}),
({ disabled }) =>
disabled && {
Expand Down
5 changes: 5 additions & 0 deletions code/core/src/components/components/form/input/input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ const styles = (({ theme }: { theme: StorybookTheme }) => ({
boxShadow: `${theme.color.secondary} 0 0 0 1px inset`,
outline: 'none',
},
'@media (forced-colors: active)': {
'&:focus': {
outline: '1px solid highlight',
},
},
'&[disabled]': {
cursor: 'not-allowed',
opacity: 0.5,
Expand Down
10 changes: 10 additions & 0 deletions code/lib/blocks/src/controls/Boolean.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ const Label = styled.label(({ theme }) => ({
outline: 'none',
boxShadow: `${theme.color.secondary} 0 0 0 1px inset !important`,
},
'@media (forced-colors: active)': {
'&:focus': {
outline: '1px solid highlight',
},
},
},

span: {
Expand Down Expand Up @@ -88,6 +93,11 @@ const Label = styled.label(({ theme }) => ({
color: theme.color.defaultText,
padding: '7px 15px',
},
'@media (forced-colors: active)': {
Copy link
Contributor

@MichaelArestad MichaelArestad Oct 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remember correctly, you can nest media queries in the above selector (below line 94) which should result in not needing to duplicate a complex selector like this one. It's just slightly tidier.

Copy link
Contributor Author

@natainakata natainakata Oct 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Media queries are now nested.
Applied to other changes as well.

'input:checked ~ span:last-of-type, input:not(:checked) ~ span:first-of-type': {
textDecoration: 'underline',
},
},
}));

const parse = (value: string | null): boolean => value === 'true';
Expand Down