-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
UI: Fix Visual Focus Indicators aren't visible in high contrast mode #29239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 56e246e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
MichaelArestad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just has one suggestion for slightly tidier code. I very much appreciate you taking the time to add these enhancements for high contrast mode. Thank you!
| color: theme.color.defaultText, | ||
| padding: '7px 15px', | ||
| }, | ||
| '@media (forced-colors: active)': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly, you can nest media queries in the above selector (below line 94) which should result in not needing to duplicate a complex selector like this one. It's just slightly tidier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Media queries are now nested.
Applied to other changes as well.
|
@natainakata thanks for your contribution! I've reopened this branch on the Storybook repo to rebase it and check the state of the CI. I'm closing this PR as a result, and I'll make sure the rebase PR gets merged. You can follow up on #29239. |
Closes #25935
What I did
Added indicator display for ActionBar, Input, and Boolean toggle, since it was not clear whether the focus was applied in High Contrast Mode.
Focus on it and the outline will appear.
The Boolean toggle further displays an underscore for the selected boolean value.
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Probably does not require manual testing.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This pull request improves accessibility for high contrast mode in Storybook's UI components.