Preview: Fix type issues

[mrginglymus]

Closes #31527

What I did

Switched an import alias. I wish I knew why this fixed it, but the offending type stub file is gone.

Presumably there's something unstable going on in rollup-plugin-dts, tsup, or somewhere else in the chain.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates the import path for ReactRenderer type from './public-types' to './types' in the React renderer to fix a type error related to global scope augmentations.

• Changed import path in code/renderers/react/src/entry-preview-argtypes.ts from './public-types' to './types'
• Resolves issue [Bug]: @storybook/react 9.0.0-rc.3 type error #31527 where observable-like.d.ts was causing TypeScript errors with global scope augmentations
• Import path change appears to be a workaround for an underlying issue in the type generation toolchain

[greptile-apps]

LGTM

_{1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile}

[mrginglymus]

Whilst playing with this I did try updating tsup and switching to Microsoft API Extractor as the more modern (and actively maintained) alternative. It seems to require some substantial configuration efforts though.

[nx-cloud]

View your CI Pipeline Execution ↗ for commit 96ed29e.

Command	Status	Duration	Result
nx run-many -t build --parallel=3	✅ Succeeded	1m 26s	View ↗

---

☁️ Nx Cloud last updated this comment at 2025-05-30 06:30:16 UTC

[JReinhold]

Can you tell me more about how Microsoft API Extractor is involved here? I don't understand what that does from the website.

[mrginglymus]

It's recommended noted (in experimental form) by tsup as being more accurate than their default dts extractor: https://tsup.egoist.dev/#generate-declaration-file

Effectively a replacement for rollup-plugin-dts, it allows you to generate a single .d.ts file for a given input, with no external dependencies.

It's likely to be considerably more accurate than rollup-plugin-dts, which frequently generates invalid typings - I've previously seen it include executable code in a .d.ts file!

---

see #31547 for a poc - tsup is now generating .d.mts files including for preview cjs files, so some fettling of package.json is required

[storybook-app-bot]

Package Benchmarks

^{Commit: 96ed29e, ran on 7 June 2025 at 05:03:06 UTC}

The following packages have significant changes to their size or dependencies:

storybook

	Before	After	Difference
Dependency count	49	49	0
Self size	31.40 MB	31.37 MB	🎉 -31 KB 🎉
Dependency size	17.41 MB	17.41 MB	0 B
Bundle Size Analyzer	Link	Link

sb

	Before	After	Difference
Dependency count	50	50	0
Self size	1 KB	1 KB	0 B
Dependency size	48.81 MB	48.78 MB	🎉 -31 KB 🎉
Bundle Size Analyzer	Link	Link

@storybook/codemod

	Before	After	Difference
Dependency count	267	267	0
Self size	31 KB	31 KB	0 B
Dependency size	82.19 MB	82.20 MB	🚨 +13 KB 🚨
Bundle Size Analyzer	Link	Link