-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Angular: Include 20.x in version range #31602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| "zone.js": "^0.15.0" | ||
| }, | ||
| "peerDependencies": { | ||
| "@angular-devkit/architect": ">=0.1800.0 < 0.2000.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Version range for @angular-devkit/architect (< 0.2000.0) is inconsistent with other Angular dependencies (< 21.0.0)
|
View your CI Pipeline Execution ↗ for commit 6a0a739.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 208 | 208 | 0 |
| Self size | 606 KB | 606 KB | 0 B |
| Dependency size | 29.59 MB | 29.72 MB | 🚨 +130 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
Angular: Include 20.x in version range (cherry picked from commit 2009e72)
Add support for Angular v20. BREAKING CHANGE: Support for Angular v17 was dropped. ### TODO - [x] Update Angular packages to the stable v20 - [x] Update `jest-preset-angular` when it releases support for Angular v20 - [x] PR: thymikee/jest-preset-angular#3119 - [x] Release: https://github.com/thymikee/jest-preset-angular/releases/tag/v14.6.0 - [ ] Update Angular ESLint packages to the v20 stable version once released - [ ] PR: angular-eslint/angular-eslint#2448 - [x] Update AnalogJS packages when they are released with support for Angular v20 - [x] PR: analogjs/analog#1751 - [x] Release: https://github.com/analogjs/analog/releases/tag/v1.17.0 - [x] Fix for `@analogjs/vitest-angular` peer deps: analogjs/analog#1754 - [x] Release: - [x] Beta: https://github.com/analogjs/analog/releases/tag/v1.17.1-beta.1 - [x] Stable: https://github.com/analogjs/analog/releases/tag/v1.17.1 - [ ] Update Storybook packages - [x] PRs: storybookjs/storybook#31602 and storybookjs/storybook#31611 - [x] Storybook 9 Release: https://github.com/storybookjs/storybook/releases/tag/v9.0.3 - [ ] Storybook 8 Release??: PENDING - [ ] Remaining issue: storybookjs/storybook#31652
Add support for Angular v20. BREAKING CHANGE: Support for Angular v17 was dropped. ### TODO - [x] Update Angular packages to the stable v20 - [x] Update `jest-preset-angular` when it releases support for Angular v20 - [x] PR: thymikee/jest-preset-angular#3119 - [x] Release: https://github.com/thymikee/jest-preset-angular/releases/tag/v14.6.0 - [ ] Update Angular ESLint packages to the v20 stable version once released - [ ] PR: angular-eslint/angular-eslint#2448 - [x] Update AnalogJS packages when they are released with support for Angular v20 - [x] PR: analogjs/analog#1751 - [x] Release: https://github.com/analogjs/analog/releases/tag/v1.17.0 - [x] Fix for `@analogjs/vitest-angular` peer deps: analogjs/analog#1754 - [x] Release: - [x] Beta: https://github.com/analogjs/analog/releases/tag/v1.17.1-beta.1 - [x] Stable: https://github.com/analogjs/analog/releases/tag/v1.17.1 - [ ] Update Storybook packages - [x] PRs: storybookjs/storybook#31602 and storybookjs/storybook#31611 - [x] Storybook 9 Release: https://github.com/storybookjs/storybook/releases/tag/v9.0.3 - [ ] Storybook 8 Release??: PENDING - [ ] Remaining issue: storybookjs/storybook#31652
Closes #
What I did
Bump Angular range to include 20.x
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Updates Angular framework integration in Storybook to support Angular 20 by extending peer dependency version ranges in
code/frameworks/angular/package.json.< 20.0.0to< 21.0.0for Angular-related packages