Skip to content

Conversation

@valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 30, 2025

Closes #

What I did

Support Angular 20

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates Angular framework package to support Angular v20 by extending peer dependency version ranges while maintaining compatibility with v18 and v19.

  • Updated @angular-devkit/architect version range from < 0.2000.0 to < 0.2100.0 in code/frameworks/angular/package.json
  • Maintains backward compatibility with Angular v18 and v19
  • DevDependencies set to Angular v19.1.1 for testing

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link

nx-cloud bot commented May 30, 2025

View your CI Pipeline Execution ↗ for commit 372e51a.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 27s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-30 06:44:19 UTC

@valentinpalkovic valentinpalkovic merged commit 68e36d8 into next May 30, 2025
63 of 71 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/support-angular-20 branch May 30, 2025 15:34
@github-actions github-actions bot mentioned this pull request May 30, 2025
11 tasks
@valentinpalkovic valentinpalkovic added the patch:yes Bugfix & documentation PR that need to be picked to main branch label May 31, 2025
@github-actions github-actions bot mentioned this pull request May 31, 2025
5 tasks
shilman pushed a commit that referenced this pull request May 31, 2025
Angular: Support v20
(cherry picked from commit 68e36d8)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label May 31, 2025
@github-actions github-actions bot mentioned this pull request May 31, 2025
12 tasks
@Tallyb
Copy link

Tallyb commented Jun 1, 2025

hi @valentinpalkovic - to support angular 20, you also need to cater to the fact that provideExperimentalZonelesschangeDetection is now provideZonelessChangeDetection.

if (STORYBOOK_ANGULAR_OPTIONS?.experimentalZoneless) {

@valentinpalkovic
Copy link
Contributor Author

Hi @Tallyb,

I will look into it! Thanks

FrozenPandaz pushed a commit to nrwl/nx that referenced this pull request Jun 6, 2025
Add support for Angular v20.

BREAKING CHANGE: Support for Angular v17 was dropped.

### TODO

- [x] Update Angular packages to the stable v20
- [x] Update `jest-preset-angular` when it releases support for Angular
v20
  - [x] PR: thymikee/jest-preset-angular#3119
- [x] Release:
https://github.com/thymikee/jest-preset-angular/releases/tag/v14.6.0
- [ ] Update Angular ESLint packages to the v20 stable version once
released
  - [ ] PR: angular-eslint/angular-eslint#2448
- [x] Update AnalogJS packages when they are released with support for
Angular v20
  - [x] PR: analogjs/analog#1751
- [x] Release: https://github.com/analogjs/analog/releases/tag/v1.17.0
- [x] Fix for `@analogjs/vitest-angular` peer deps:
analogjs/analog#1754
    - [x] Release:
- [x] Beta:
https://github.com/analogjs/analog/releases/tag/v1.17.1-beta.1
- [x] Stable: https://github.com/analogjs/analog/releases/tag/v1.17.1
- [ ] Update Storybook packages
- [x] PRs: storybookjs/storybook#31602 and
storybookjs/storybook#31611
- [x] Storybook 9 Release:
https://github.com/storybookjs/storybook/releases/tag/v9.0.3
  - [ ] Storybook 8 Release??: PENDING
- [ ] Remaining issue:
storybookjs/storybook#31652
ndcunningham pushed a commit to nrwl/nx that referenced this pull request Jul 30, 2025
Add support for Angular v20.

BREAKING CHANGE: Support for Angular v17 was dropped.

### TODO

- [x] Update Angular packages to the stable v20
- [x] Update `jest-preset-angular` when it releases support for Angular
v20
  - [x] PR: thymikee/jest-preset-angular#3119
- [x] Release:
https://github.com/thymikee/jest-preset-angular/releases/tag/v14.6.0
- [ ] Update Angular ESLint packages to the v20 stable version once
released
  - [ ] PR: angular-eslint/angular-eslint#2448
- [x] Update AnalogJS packages when they are released with support for
Angular v20
  - [x] PR: analogjs/analog#1751
- [x] Release: https://github.com/analogjs/analog/releases/tag/v1.17.0
- [x] Fix for `@analogjs/vitest-angular` peer deps:
analogjs/analog#1754
    - [x] Release:
- [x] Beta:
https://github.com/analogjs/analog/releases/tag/v1.17.1-beta.1
- [x] Stable: https://github.com/analogjs/analog/releases/tag/v1.17.1
- [ ] Update Storybook packages
- [x] PRs: storybookjs/storybook#31602 and
storybookjs/storybook#31611
- [x] Storybook 9 Release:
https://github.com/storybookjs/storybook/releases/tag/v9.0.3
  - [ ] Storybook 8 Release??: PENDING
- [ ] Remaining issue:
storybookjs/storybook#31652
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

angular ci:normal feature request patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants