Skip to content

Conversation

@valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented May 31, 2025

Relates #31620

What I did

Remove version specifier of @chromatic-com/storybook addon.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates version handling for @chromatic-com/storybook package to use latest versions without specific constraints across multiple files.

  • Modified code/lib/create-storybook/src/generators/baseGenerator.ts to remove @^4 version specifier
  • Updated code/package.json to use ^4.0.0 instead of ^4.0.0-0
  • Adjusted version expectations in code/lib/cli-storybook/src/upgrade.test.ts from '4.0.0-0' to '4.0.0'
  • Ensures consistent version handling across codebase for chromatic-com/storybook packages

@valentinpalkovic valentinpalkovic self-assigned this May 31, 2025
@valentinpalkovic valentinpalkovic added bug patch:yes Bugfix & documentation PR that need to be picked to main branch addon: visual test ci:normal labels May 31, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link

nx-cloud bot commented May 31, 2025

View your CI Pipeline Execution ↗ for commit 1e1d19e.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-16 08:46:22 UTC

@valentinpalkovic valentinpalkovic merged commit 76f1eca into next Jun 16, 2025
56 of 57 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/use-latest-version-of-chromatic-com-storybook branch June 16, 2025 11:16
valentinpalkovic added a commit that referenced this pull request Jun 17, 2025
…n-of-chromatic-com-storybook

Addons: Use chromatic-com/storybook without version specifier
(cherry picked from commit 76f1eca)
@github-actions github-actions bot mentioned this pull request Jun 17, 2025
7 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 17, 2025
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: visual test bug ci:normal patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants