Skip to content

Conversation

@shilman
Copy link
Member

@shilman shilman commented Jun 14, 2025

Closes N/A

What I did

Add a new "Both" option for RN projects:

image

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

npm create expo empty-expo
cd empty-expo
/path/to/storybook/code/lib/create-storybook/bin/index.cjs

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Added a new 'Both' initialization option in Storybook CLI for React Native projects, enabling simultaneous setup of both native and web configurations.

  • Added REACT_NATIVE_AND_RNW project type to code/core/src/cli/project_types.ts
  • Implemented dual initialization logic in code/lib/create-storybook/src/initiate.ts to run both RN and RNW generators
  • Improved CLI to handle installation messages for both native and web configurations separately
  • Added new selection option in the CLI interface for the 'Both' configuration
  • Note: Template configuration needs to be added to supportedTemplates array for complete implementation

@shilman shilman self-assigned this Jun 14, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

@nx-cloud
Copy link

nx-cloud bot commented Jun 14, 2025

View your CI Pipeline Execution ↗ for commit ddd66b1.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 11s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-15 01:55:21 UTC

@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Jun 14, 2025
Copy link
Contributor

@jonniebigodes jonniebigodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shilman, thank you for taking the time to adjust the documentation. I appreciate it. I left one small item for you to look into when you can. Let me know, and we'll go from there.

Approving to unblock you.

@shilman shilman merged commit ae63ac4 into next Jun 15, 2025
56 of 57 checks passed
@shilman shilman deleted the shilman/cli-rn-rnw-both-option branch June 15, 2025 08:39
@github-actions github-actions bot mentioned this pull request Jun 15, 2025
4 tasks
shilman added a commit that referenced this pull request Jun 15, 2025
…tion

CLI: Add RN/RNW "both" init option
(cherry picked from commit ae63ac4)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 15, 2025
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
71 tasks
@ndelangen ndelangen removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch react-native react-native-web

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants