-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
CLI: Add RN/RNW "both" init option #31778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit ddd66b1.
☁️ Nx Cloud last updated this comment at |
jonniebigodes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shilman, thank you for taking the time to adjust the documentation. I appreciate it. I left one small item for you to look into when you can. Let me know, and we'll go from there.
Approving to unblock you.
Co-authored-by: jonniebigodes <[email protected]>
…tion CLI: Add RN/RNW "both" init option (cherry picked from commit ae63ac4)
Closes N/A
What I did
Add a new "Both" option for RN projects:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Added a new 'Both' initialization option in Storybook CLI for React Native projects, enabling simultaneous setup of both native and web configurations.
REACT_NATIVE_AND_RNWproject type tocode/core/src/cli/project_types.tscode/lib/create-storybook/src/initiate.tsto run both RN and RNW generatorssupportedTemplatesarray for complete implementation