Core: Gracefully handle disallowed cross-origin clipboard access #31834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghengeveld
added
bug
patch:yes
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
LGTM
1 file reviewed, no comments
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 8d2d9c9.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit 8d2d9c9.
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 49 | 49 | 0 |
| Self size | 31.85 MB | 31.87 MB | 🚨 +16 KB 🚨 |
| Dependency size | 17.41 MB | 17.41 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 50 | 50 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 49.26 MB | 49.27 MB | 🚨 +16 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 216 | 216 | 0 |
| Self size | 582 KB | 582 KB | 0 B |
| Dependency size | 94.58 MB | 94.59 MB | 🚨 +16 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 185 | 185 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 78.71 MB | 78.72 MB | 🚨 +16 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
valentinpalkovic
approved these changes
Jun 23, 2025
This was referenced Jun 23, 2025
Merged
ghengeveld
pushed a commit
that referenced
this pull request
Jun 24, 2025
…ard-access Core: Gracefully handle disallowed cross-origin clipboard access (cherry picked from commit c2c6aaa)
github-actions
bot
added
the
patch:done
This was referenced Aug 18, 2025
ndelangen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31791
What I did
Adds a try/catch around the call to
window.top.navigator.clipboardand falls back towindow.navigator.clipboardif it fails, which usually happens when loading Storybook in an iframe such as on StackBlitz.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-31834-sha-8d2d9c94. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-31834-sha-8d2d9c94handle-cross-origin-clipboard-access8d2d9c941750429746)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=31834Greptile Summary
Improves clipboard access handling in Storybook by implementing a graceful fallback mechanism when running in cross-origin iframes like StackBlitz.
window.top.navigator.clipboardaccess incode/core/src/components/components/syntaxhighlighter/syntaxhighlighter.tsxwindow.navigator.clipboardwhen top-level clipboard access fails