UI: Fix interaction step collapse icon #31853
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 file reviewed, 1 comment
Edit PR Review Bot Settings | Greptile
Package BenchmarksCommit: No significant changes detected, all good. 👏 |
|
View your CI Pipeline Execution ↗ for commit ba59f68.
☁️ Nx Cloud last updated this comment at |
Sidnioulz
left a comment
Sidnioulz
left a comment
There was a problem hiding this comment.
LGTM but please switch the icons to chevrons instead.
| import { IconButton, TooltipNote, WithTooltip } from 'storybook/internal/components'; | ||
|
|
||
| import { ListUnorderedIcon } from '@storybook/icons'; | ||
| import { ArrowSolidDownIcon, ArrowSolidUpIcon } from '@storybook/icons'; |
There was a problem hiding this comment.
| import { ArrowSolidDownIcon, ArrowSolidUpIcon } from '@storybook/icons'; | |
| import { ChevronDownIcon, ChevronUpIcon } from '@storybook/icons'; |
| onClick={toggleCollapsed} | ||
| aria-label={isCollapsed ? 'Expand interaction' : 'Collapse interaction'} | ||
| > | ||
| {isCollapsed ? <ArrowSolidDownIcon /> : <ArrowSolidUpIcon />} |
There was a problem hiding this comment.
| {isCollapsed ? <ArrowSolidDownIcon /> : <ArrowSolidUpIcon />} | |
| {isCollapsed ? <ChevronDownIcon /> : <ChevronUpIcon />} |
This would be the icon we want to use for collapse/expand.
|
It will probably be merged tomorrow. I'm a reviewer but not a maintainer,
so my approved PRs are usually reassigned to a core team member on the
weekly meetings on Monday. If your CI is all green, it should be over very
soon :)
|
great, thank you:) |
valentinpalkovic
changed the title
3 participants
Related to #31701. Does not close the issue.
What I did
change interaction step collapse icon to arrowUp/ arrowDown and add an aria-label to the icon
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>