Skip to content

Conversation

@ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Jun 24, 2025

What I did

Extends all peerDependency definitions for vite to include 7.0.0 which was recently released. Additionally, it bumps Vitest to 3.2.4 as v3.2 is required for Vite 7.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@ghengeveld ghengeveld added dependencies patch:yes Bugfix & documentation PR that need to be picked to main branch ci:normal labels Jun 24, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

14 files reviewed, no comments
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@JReinhold JReinhold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghengeveld ghengeveld requested a review from kasperpeulen June 25, 2025 10:10
@ghengeveld ghengeveld moved this to In Progress in Core Team Projects Jun 25, 2025
@ghengeveld ghengeveld self-assigned this Jun 25, 2025
@ghengeveld ghengeveld requested a review from kasperpeulen June 25, 2025 11:10
@ghengeveld ghengeveld force-pushed the upgrade-vite-7.0.0 branch from 82c943b to a98d6e0 Compare June 25, 2025 13:41
@nx-cloud
Copy link

nx-cloud bot commented Jun 25, 2025

View your CI Pipeline Execution ↗ for commit 474c2a9.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 13s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-25 14:06:40 UTC

@storybook-app-bot
Copy link

Package Benchmarks

Commit: 474c2a9, ran on 25 June 2025 at 13:57:57 UTC

The following packages have significant changes to their size or dependencies:

storybook

Before After Difference
Dependency count 49 51 🚨 +2 🚨
Self size 31.85 MB 31.73 MB 🎉 -119 KB 🎉
Dependency size 17.41 MB 17.43 MB 🚨 +22 KB 🚨
Bundle Size Analyzer Link Link

sb

Before After Difference
Dependency count 50 52 🚨 +2 🚨
Self size 1 KB 1 KB 0 B
Dependency size 49.26 MB 49.16 MB 🎉 -97 KB 🎉
Bundle Size Analyzer Link Link

@storybook/cli

Before After Difference
Dependency count 216 218 🚨 +2 🚨
Self size 582 KB 582 KB 0 B
Dependency size 94.88 MB 94.81 MB 🎉 -64 KB 🎉
Bundle Size Analyzer Link Link

@storybook/codemod

Before After Difference
Dependency count 185 187 🚨 +2 🚨
Self size 31 KB 31 KB 0 B
Dependency size 79.01 MB 78.91 MB 🎉 -97 KB 🎉
Bundle Size Analyzer Link Link

create-storybook

Before After Difference
Dependency count 1 1 0
Self size 12.47 MB 12.50 MB 🚨 +32 KB 🚨
Dependency size 98 KB 98 KB 0 B
Bundle Size Analyzer Link Link

@ghengeveld ghengeveld merged commit 48e565a into next Jun 25, 2025
57 checks passed
@ghengeveld ghengeveld deleted the upgrade-vite-7.0.0 branch June 25, 2025 14:18
@github-project-automation github-project-automation bot moved this from In Progress to Done in Core Team Projects Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal dependencies patch:done Patch/release PRs already cherry-picked to main/release branch

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants