-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Addon Vitest: Fix support for plain stories.tsx files
#32041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewing changes made in this pull request
|
View your CI Pipeline Execution ↗ for commit 86cf4e4
☁️ Nx Cloud last updated this comment at |
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 51 | 51 | 0 |
| Self size | 31.75 MB | 31.76 MB | 🚨 +15 KB 🚨 |
| Dependency size | 17.43 MB | 17.43 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 52 | 52 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 49.18 MB | 49.20 MB | 🚨 +15 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 217 | 217 | 0 |
| Self size | 582 KB | 582 KB | 0 B |
| Dependency size | 93.66 MB | 93.68 MB | 🚨 +18 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 186 | 186 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 77.76 MB | 77.77 MB | 🚨 +12 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
…ries-tsx Addon Vitest: Fix support for plain `stories.tsx` files (cherry picked from commit 6ac71c2)
Closes #31966
What I did
Removed a check against a file pattern in the vitest transformer which was preventing
stories.tsxfiles from being transformed, thereby crashing Vitest. We already check against stories globs higher up the chain so we don't need the check in the transformer.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This PR removes an overly restrictive file pattern check in the Vitest transformer that was preventing files named
stories.tsx(without a component prefix) from being properly processed. The change simplifies the code by removing redundant validation that was already being handled by Storybook's glob patterns higher up in the build chain.This fix addresses issue #31966 where files named
stories.tsxwere being skipped by the transformer, causing Vitest to crash. The removed check was superfluous since Storybook already handles story file detection through its glob patterns at a higher level.The changes involve:
.stor(y|ies)\.regex check from the transformerConfidence score: 5/5
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile