Telemetry: Send index stats on dev exit #32168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit ebc6ced
☁️ Nx Cloud last updated this comment at |
shilman
added
maintenance
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 51 | 51 | 0 |
| Self size | 41.36 MB | 41.76 MB | 🚨 +405 KB 🚨 |
| Dependency size | 18.13 MB | 18.13 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
sb
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 52 | 52 | 0 |
| Self size | 1 KB | 1 KB | 0 B |
| Dependency size | 59.49 MB | 59.90 MB | 🚨 +405 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 220 | 220 | 0 |
| Self size | 585 KB | 585 KB | 0 B |
| Dependency size | 103.95 MB | 104.36 MB | 🚨 +405 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
@storybook/codemod
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 189 | 189 | 0 |
| Self size | 31 KB | 31 KB | 0 B |
| Dependency size | 88.04 MB | 88.45 MB | 🚨 +405 KB 🚨 |
| Bundle Size Analyzer | Link | Link |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
tmeasday
reviewed
Aug 1, 2025
tmeasday
reviewed
Aug 1, 2025
shilman
force-pushed
the
shilman/add-dev-cancel-event
branch
from
6d84768 to
afa539f
Compare
yannbf
reviewed
Aug 1, 2025
shilman
force-pushed
the
shilman/add-dev-cancel-event
branch
from
afa539f to
ebc6ced
Compare
yannbf
approved these changes
Aug 1, 2025
This was referenced Aug 1, 2025
Merged
yannbf
pushed a commit
that referenced
this pull request
Aug 4, 2025
Telemetry: Send index stats on dev exit (cherry picked from commit c5d386f)
github-actions
bot
added
the
patch:done
4 tasks
This was referenced Aug 18, 2025
ndelangen
removed
the
patch:yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
Send
canceled(dev)with index stats ondevexitChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Here's how I tested:
storybook devwithSTORYBOOK_TELEMETRY_DEBUG=1deveventcanceled(dev)event gets sent with updated index stats🦋 Canary release
This pull request has been released as version
0.0.0-pr-32168-sha-afa539f0. Try it out in a new sandbox by runningnpx [email protected] sandboxor in an existing project withnpx [email protected] upgrade.More information
0.0.0-pr-32168-sha-afa539f0shilman/add-dev-cancel-eventafa539f01754039474)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=32168