Skip to content

Conversation

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Sep 17, 2025

What I did

I created a canary for testing addon-designs with sb10.
This canary is ESM-only, and tested here.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated a design tooling dependency used in Storybook to a newer version to keep our internal tooling current.
    • This change does not affect app functionality, performance, or the user interface.
    • No user-facing features were added or modified, and there are no changes to public APIs.

@ndelangen ndelangen self-assigned this Sep 17, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 17, 2025

Walkthrough

Updated a development dependency: @storybook/addon-designs in code/package.json was bumped from 9.0.0-next.1 to 10.0.3--canary.67522d1.0. No other files, logic, or public APIs were changed.

Changes

Cohort / File(s) Summary
Dependency version bump
code/package.json
Updated @storybook/addon-designs version from 9.0.0-next.1 to 10.0.3--canary.67522d1.0. No other dependency changes.

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I nudge a number, hop—no fuss,
A canary hums, designs discuss.
No code to tangle, no tests to mend,
Just fresher carrots for Storybook’s friend. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Build: Update addon-designs to sb10 canary" succinctly and accurately summarizes the primary change in this PR — bumping the addon-designs dependency to a Storybook 10 canary. It is a short, single sentence that clearly communicates the main intent for reviewers scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch norbert/bump-addon-designs-to-sb10-canary

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a8ba6a1 and 5335ed9.

⛔ Files ignored due to path filters (1)
  • code/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • code/package.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • code/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link

nx-cloud bot commented Sep 17, 2025

View your CI Pipeline Execution ↗ for commit 5335ed9

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 50s View ↗

☁️ Nx Cloud last updated this comment at 2025-09-17 21:35:42 UTC

@ndelangen ndelangen requested a review from shilman September 17, 2025 21:13
@ndelangen ndelangen merged commit 39f52e4 into next Sep 18, 2025
58 checks passed
@ndelangen ndelangen deleted the norbert/bump-addon-designs-to-sb10-canary branch September 18, 2025 08:05
@github-actions github-actions bot mentioned this pull request Sep 18, 2025
16 tasks
@ndelangen ndelangen added build Internal-facing build tooling & test updates and removed dependencies labels Sep 19, 2025
@coderabbitai coderabbitai bot mentioned this pull request Oct 28, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal compatibility with other tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants