Skip to content

Conversation

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 28, 2025

What I did

Upgrade to latest version of addon-design

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Upgraded the Storybook design addon to the new major release to keep the UI preview tooling current.
    • Changed how the Storybook test-runner dependency is referenced so installing extra Storybook dev tools pulls the latest test-runner version.
    • Bumped a Storybook/Next.js integration plugin to a patch release to ensure compatibility and minor fixes.

@ndelangen ndelangen changed the title Upgrade @storybook/addon-designs from version 10.0.3--canary.67522d1.0 to 11.0.0 in package.json and yarn.lock Upgrade: @storybook/addon-designs to v11 Oct 28, 2025
@ndelangen ndelangen self-assigned this Oct 28, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 28, 2025

📝 Walkthrough

Walkthrough

Bumped three dev-facing dependency specs: @storybook/addon-designs in code/package.json from a canary v10 → ^11.0.0; changed @storybook/test-runner in scripts/tasks/sandbox-parts.ts from @next@latest; and bumped vite-plugin-storybook-nextjs in code/frameworks/nextjs-vite/package.json ^3.0.0 → ^3.0.1.

Changes

Cohort / File(s) Summary
Storybook addon manifest
code/package.json
Upgraded @storybook/addon-designs from 10.0.3--canary.67522d1.0^11.0.0.
Sandbox task dependency
scripts/tasks/sandbox-parts.ts
Changed extra dev dependency spec: @storybook/test-runner@next@storybook/test-runner@latest.
NextJS Vite framework
code/frameworks/nextjs-vite/package.json
Bumped vite-plugin-storybook-nextjs from ^3.0.0^3.0.1.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Pay attention to potential breaking changes or peer-dependency shifts for @storybook/addon-designs@^11.0.0.
  • Verify sandbox behavior where @storybook/test-runner@latest may differ from @next.
  • Confirm the nextjs-vite plugin patch bump doesn't require config tweaks.

Possibly related PRs

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch norbert/bump-addon-designs

Comment @coderabbitai help to get the list of available commands and usage tips.

@ndelangen ndelangen added ci:normal cleanup Minor cleanup style change that won't show up in release changelog labels Oct 28, 2025
@ndelangen ndelangen marked this pull request as ready for review October 28, 2025 13:05
@ndelangen ndelangen requested a review from yannbf October 28, 2025 13:05
coderabbitai[bot]

This comment was marked as resolved.

@nx-cloud
Copy link

nx-cloud bot commented Oct 28, 2025

View your CI Pipeline Execution ↗ for commit 6835d3d

Command Status Duration Result
nx run-many -t check -c production --parallel=7 ✅ Succeeded 1s View ↗
nx run-many -t build -c production --parallel=3 ✅ Succeeded 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-28 14:29:58 UTC

@ndelangen ndelangen changed the title Upgrade: @storybook/addon-designs to v11 Upgrade: Satelite repos Oct 28, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
scripts/tasks/sandbox-parts.ts (1)

86-86: Consider using the project's logger instead of console.

The coding guidelines specify using storybook/internal/node-logger instead of console.* for Node.js scripts. While this is pre-existing code, consider updating it in a follow-up to align with project standards.

Based on coding guidelines.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ed1a258 and 58d2794.

📒 Files selected for processing (1)
  • scripts/tasks/sandbox-parts.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{js,jsx,json,html,ts,tsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{js,jsx,json,html,ts,tsx,mjs}: Run Prettier formatting on changed files before committing
Run ESLint on changed files and fix all errors/warnings before committing (use yarn lint:js:cmd <file>)

Files:

  • scripts/tasks/sandbox-parts.ts
**/*.{ts,tsx,js,jsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Export functions from modules when they need to be unit-tested

Files:

  • scripts/tasks/sandbox-parts.ts
scripts/**/*.{ts,js,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

In Node.js scripts, use storybook/internal/node-logger instead of console.*

Files:

  • scripts/tasks/sandbox-parts.ts
{code/**,scripts/**}/**/*.{ts,tsx,js,jsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not use console.log, console.warn, or console.error directly unless in isolated files where importing loggers would significantly increase bundle size

Files:

  • scripts/tasks/sandbox-parts.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest
🔇 Additional comments (1)
scripts/tasks/sandbox-parts.ts (1)

544-544: Confirm intent: This changes from a pre-release to a lower stable version.

The change moves from @storybook/test-runner@next (0.24.0-next.4) to @storybook/test-runner@latest (0.23.0)—a version downgrade despite moving to the stable channel. While no security vulnerabilities exist and the change is syntactically valid, verify this downgrade aligns with the PR's upgrade objectives. If you intended to use the latest available version, @next or an explicit @0.24.0-next.4 may be more appropriate.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 58d2794 and 6835d3d.

⛔ Files ignored due to path filters (1)
  • code/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (1)
  • code/frameworks/nextjs-vite/package.json (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,json,html,ts,tsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{js,jsx,json,html,ts,tsx,mjs}: Run Prettier formatting on changed files before committing
Run ESLint on changed files and fix all errors/warnings before committing (use yarn lint:js:cmd <file>)

Files:

  • code/frameworks/nextjs-vite/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest

@ndelangen ndelangen merged commit 7e50eb0 into next Oct 28, 2025
59 checks passed
@ndelangen ndelangen deleted the norbert/bump-addon-designs branch October 28, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:normal cleanup Minor cleanup style change that won't show up in release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants