-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Fix(tags): Update documentation link anchor in TagsFilterPanel #32668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(tags): Update documentation link anchor in TagsFilterPanel #32668
Conversation
📝 WalkthroughWalkthroughUpdated a docs link in TagsFilterPanel’s development-only menu and adjusted two light theme syntax color literals in theming. No changes to exports, logic, or control flow. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
code/core/src/manager/components/sidebar/TagsFilterPanel.tsx(1 hunks)code/core/src/theming/convert.ts(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Adhere to ESLint and Prettier rules across all JS/TS source files
Files:
code/core/src/theming/convert.tscode/core/src/manager/components/sidebar/TagsFilterPanel.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Fix type errors and prefer precise typings instead of using any or suppressions, consistent with strict mode
Files:
code/core/src/theming/convert.tscode/core/src/manager/components/sidebar/TagsFilterPanel.tsx
🔇 Additional comments (1)
code/core/src/theming/convert.ts (1)
15-15: Clarify undocumented color changes in convert.ts
Confirm whether the updates to red4 (#D24400) and cyan2 (#24659F) in code/core/src/theming/convert.ts (lines 15, 18) are intentional enhancements or unintended edits that should be reverted.
code/core/src/theming/convert.ts
Outdated
| red4: '#D24400', | ||
| gray1: '#393A34', | ||
| cyan1: '#36acaa', | ||
| cyan2: '#2B91AF', | ||
| cyan2: '#24659F', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were these colors changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yannbf, that's a great question!
You are seeing the color changes because they were merged into my feature branch from a separate, earlier PR that focused on style.
The changes themselves were made to refine the red and cyan syntax colors in the light theme to improve contrast and overall readability for our users, as mentioned in the summary.
This PR's main purpose is just the documentation link fix in the TagsFilterPanel.tsx file (the 7d1679f commit). Sorry for the confusion!
|
View your CI Pipeline Execution ↗ for commit 4e4c61b
☁️ Nx Cloud last updated this comment at |
|
Merging this as it's technically a bug and before we forget about it and have to patch it back. It's best to get it in as soon as possible |
Closes #32662
What I did
his PR fixes the broken documentation link for "Learn how to add tags" in the Tags dropdown menu (
TagsFilterPanel).The anchor tag for the documentation has changed in the Storybook documentation from
#filtering-by-custom-tagsto#custom-tags.The changes in this PR are covered in the following automated tests:
Manual testing
Note for Reviewer: I was unable to run the project locally due to setup/build errors, so I could not perform manual verification.
Steps to test (for Reviewer):
https://storybook.js.org/docs/10/writing-stories/tags#custom-tags).Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Summary by CodeRabbit
Documentation
Style