Skip to content

Fix(tags): Update documentation link anchor in TagsFilterPanel #32668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonniebigodes merged 10 commits into from
Oct 14, 2025
Merged

Fix(tags): Update documentation link anchor in TagsFilterPanel #32668

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
275afb8
Add a correct color contrast
JatinMehta007 Sep 22, 2025
ebbcdbf
Merge pull request #1 from JatinMehta007/color-contrast
JatinMehta007 Sep 23, 2025
024e17e
Merge branch 'storybookjs:next' into next
JatinMehta007 Oct 7, 2025
7d1679f
Update documentation link anchor in TagsFilterPanel
JatinMehta007 Oct 7, 2025
79fb14f
Merge branch 'next' into fix/TagsFilterPanel
valentinpalkovic Oct 13, 2025
988ea6d
Update code/core/src/theming/convert.ts
valentinpalkovic Oct 13, 2025
feb2808
Update code/core/src/theming/convert.ts
valentinpalkovic Oct 13, 2025
574e4a7
Merge branch 'next' into fix/TagsFilterPanel
jonniebigodes Oct 13, 2025
9d8bead
Merge branch 'next' into fix/TagsFilterPanel
jonniebigodes Oct 14, 2025
4e4c61b
Merge branch 'next' into fix/TagsFilterPanel
jonniebigodes Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion code/core/src/manager/components/sidebar/TagsFilterPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ export const TagsFilterPanel = ({
title: 'Learn how to add tags',
icon: <DocumentIcon />,
right: <ShareAltIcon />,
href: api.getDocsUrl({ subpath: 'writing-stories/tags#filtering-by-custom-tags' }),
href: api.getDocsUrl({ subpath: 'writing-stories/tags#custom-tags' }),
},
]);
}
Expand Down
4 changes: 2 additions & 2 deletions code/core/src/theming/convert.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ const lightSyntaxColors = {
red1: '#A31515',
red2: '#9a050f',
red3: '#800000',
red4: '#ff0000',
red4: '#D24400',
gray1: '#393A34',
cyan1: '#36acaa',
cyan2: '#2B91AF',
cyan2: '#24659F',
Copy link
Member

@yannbf yannbf Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were these colors changed?

Copy link
Contributor Author

@JatinMehta007 JatinMehta007 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @yannbf, that's a great question!

You are seeing the color changes because they were merged into my feature branch from a separate, earlier PR that focused on style.

The changes themselves were made to refine the red and cyan syntax colors in the light theme to improve contrast and overall readability for our users, as mentioned in the summary.

This PR's main purpose is just the documentation link fix in the TagsFilterPanel.tsx file (the 7d1679f commit). Sorry for the confusion!

blue1: '#0000ff',
blue2: '#00009f',
};
Expand Down