Skip to content

Conversation

@ndelangen
Copy link
Member

@ndelangen ndelangen commented Oct 20, 2025

What I did

use next version of the test-runner to test the storybook monorepo with it.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook publish.yml --field pr=<PR_NUMBER>

Summary by CodeRabbit

  • Chores
    • Updated internal development tooling dependencies.

@ndelangen ndelangen added test-runner build Internal-facing build tooling & test updates ci:normal labels Oct 20, 2025
@ndelangen ndelangen self-assigned this Oct 20, 2025
@ndelangen ndelangen requested a review from yannbf October 20, 2025 12:24
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

📝 Walkthrough

Walkthrough

Updated the Storybook test-runner dependency version in the sandbox parts build task from a canary release to the @next channel, modifying a single version string in the development dependencies configuration.

Changes

Cohort / File(s) Summary
Dependency version update
scripts/tasks/sandbox-parts.ts
Changed @storybook/test-runner version from 0.23.1--canary.d0c3175.0 to @next in the addExtraDependencies function

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch norbert/test-runner-bump

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6d7ff1d and b953830.

📒 Files selected for processing (1)
  • scripts/tasks/sandbox-parts.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{js,jsx,json,html,ts,tsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{js,jsx,json,html,ts,tsx,mjs}: Run Prettier formatting on changed files before committing
Run ESLint on changed files and fix all errors/warnings before committing (use yarn lint:js:cmd <file>)

Files:

  • scripts/tasks/sandbox-parts.ts
**/*.{ts,tsx,js,jsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Export functions from modules when they need to be unit-tested

Files:

  • scripts/tasks/sandbox-parts.ts
scripts/**/*.{ts,js,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

In Node.js scripts, use storybook/internal/node-logger instead of console.*

Files:

  • scripts/tasks/sandbox-parts.ts
{code/**,scripts/**}/**/*.{ts,tsx,js,jsx,mjs}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Do not use console.log, console.warn, or console.error directly unless in isolated files where importing loggers would significantly increase bundle size

Files:

  • scripts/tasks/sandbox-parts.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Danger JS
  • GitHub Check: normal
  • GitHub Check: Core Unit Tests, windows-latest
🔇 Additional comments (1)
scripts/tasks/sandbox-parts.ts (1)

544-544: Confirm the intent of using the floating @next dist-tag for test-runner.

The concern about reproducibility is valid: the @next tag currently resolves to 0.24.0-next.2 and will float to subsequent next releases as they're published. While this may be intentional for sandbox environments that test latest pre-releases, it introduces non-deterministic builds.

The version also represents a bump from the previous pinned 0.23.1--canary.d0c3175.0 to 0.24.0-next.2. Confirm whether:

  • This floating version approach is intentional for sandbox testing
  • The version bump to 0.24.0-next is compatible with related code

If reproducibility is important, consider pinning to the specific next version (e.g., @storybook/[email protected]) or documenting the rationale for using a floating tag.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ndelangen ndelangen marked this pull request as ready for review October 20, 2025 12:25
@nx-cloud
Copy link

nx-cloud bot commented Oct 20, 2025

View your CI Pipeline Execution ↗ for commit 013435c

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 46s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-21 08:19:20 UTC

@ndelangen
Copy link
Member Author

ndelangen commented Oct 20, 2025

The CI is running into this error:

storybook is listed by your project with version 10.0.0-beta.13 (p230054), which doesn't satisfy what @storybook/test-runner and other dependencies request (but they have non-overlapping ranges!)

It's because the release of the test-runner didn't work:
https://github.com/storybookjs/test-runner/actions/runs/18649813777/job/53164992412

@yannbf

@ndelangen ndelangen merged commit 8f66a21 into next Oct 21, 2025
57 checks passed
@ndelangen ndelangen deleted the norbert/test-runner-bump branch October 21, 2025 08:19
@coderabbitai coderabbitai bot mentioned this pull request Oct 28, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Internal-facing build tooling & test updates ci:normal test-runner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants