Build: Try out NX agents #33150
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,3 @@ | ||||||||||||||||
| STORYBOOK_DISABLE_TELEMETRY=true | ||||||||||||||||
| IN_STORYBOOK_SANDBOX=true | ||||||||||||||||
| SANDBOX_ROOT=../storybook-sandboxes | ||||||||||||||||
|
Comment on lines
+1
to
+3
Contributor
There was a problem hiding this comment. 🧩 Analysis chainScript executed: #!/bin/bash
# Check if .env file exists and display its contents with line numbers
echo "=== Checking .env file ==="
if [ -f .env ]; then
cat -n .env
echo "File size: $(wc -l < .env) lines"
echo "Hex dump (to check for trailing newline):"
tail -c 20 .env | od -c
else
echo ".env file not found"
fi
# Check .gitignore to see if .env is tracked
echo -e "\n=== Checking .gitignore ==="
if [ -f .gitignore ]; then
rg -n "\.env" .gitignore || echo "No .env patterns found in .gitignore"
fi
# Look for .env.example or similar template files
echo -e "\n=== Looking for .env template files ==="
fd -e example -e template -e sample | grep -i env || echo "No .env template files found"
fd "\.env\." || echo "No .env variant files found"
# Check git status for .env
echo -e "\n=== Git status for .env ==="
git status .env 2>/dev/null || echo "Not a git repo or file not tracked"
# Look for any dotenv or .env configuration documentation
echo -e "\n=== Checking for .env documentation ==="
fd -type f \( -name "*.md" -o -name "*.txt" \) | xargs grep -l "\.env" 2>/dev/null | head -5 || echo "No .env documentation found"Repository: storybookjs/storybook <shell_result> stdout: stderr: </shell_result> Script executed: #!/bin/bash
# Search for references to these environment variables
echo "=== Searching for SANDBOX_ROOT usage ==="
rg "SANDBOX_ROOT" -A 2 -B 2 | head -20
echo -e "\n=== Searching for IN_STORYBOOK_SANDBOX usage ==="
rg "IN_STORYBOOK_SANDBOX" -A 2 -B 2 | head -20
echo -e "\n=== Searching for STORYBOOK_DISABLE_TELEMETRY usage ==="
rg "STORYBOOK_DISABLE_TELEMETRY" -A 2 -B 2 | head -20
# Check if there's a dotenv-linter config
echo -e "\n=== Looking for dotenv-linter config ==="
fd -name ".dotenv*" -o -name "dotenv*" 2>/dev/null | head -10
# Check NX agents.yaml mentioned in review
echo -e "\n=== Checking .nx/workflows/agents.yaml ==="
if [ -f .nx/workflows/agents.yaml ]; then
rg "SANDBOX_ROOT" .nx/workflows/agents.yaml
else
echo "agents.yaml not found"
fi
# Look for any CI/CD or config files that reference .env
echo -e "\n=== Checking for .env usage in config files ==="
find . -maxdepth 2 -type f \( -name "*.json" -o -name "*.yml" -o -name "*.yaml" \) | xargs grep -l "\.env" 2>/dev/null | head -5Repository: storybookjs/storybook <shell_result> stdout: </shell_result> Script executed: #!/bin/bash
# Search for any dotenv-linter configuration or references
echo "=== Checking for dotenv-linter references ==="
rg "dotenv.linter\|dotenv-linter" --type json --type yaml --type toml 2>/dev/null | head -20
# Check package.json or similar for dotenv-linter
echo -e "\n=== Checking for linter configuration in package.json ==="
if [ -f package.json ]; then
cat package.json | grep -A 10 -B 2 "dotenv\|linter" || echo "No dotenv-linter config in package.json"
fi
# Check if there's a .dotenv-lintrc or similar
echo -e "\n=== Looking for dotenv config files ==="
find . -maxdepth 3 -type f \( -name ".dotenv-lintrc*" -o -name "dotenv-lint*" \) 2>/dev/null
# Check PR or issue context for the linter mention
echo -e "\n=== Checking git log for dotenv-linter references ==="
git log --all --oneline --grep="dotenv" 2>/dev/null | head -10
echo -e "\n=== Checking if .env is explicitly listed in git ==="
git ls-files .env 2>/dev/null && echo ".env is tracked in git" || echo ".env is not tracked"Repository: storybookjs/storybook <shell_result> stdout: </shell_result> Fix alphabetical ordering and add trailing newline to The environment variables should be ordered alphabetically, and the file is missing a trailing newline. The Apply this diff: -STORYBOOK_DISABLE_TELEMETRY=true
-IN_STORYBOOK_SANDBOX=true
+IN_STORYBOOK_SANDBOX=true
SANDBOX_ROOT=../storybook-sandboxes
+STORYBOOK_DISABLE_TELEMETRY=true
+📝 Committable suggestion
Suggested change
🧰 Tools🪛 dotenv-linter (4.0.0)[warning] 2-2: [UnorderedKey] The IN_STORYBOOK_SANDBOX key should go before the STORYBOOK_DISABLE_TELEMETRY key (UnorderedKey) [warning] 3-3: [EndingBlankLine] No blank line at the end of the file (EndingBlankLine) [warning] 3-3: [UnorderedKey] The SANDBOX_ROOT key should go before the STORYBOOK_DISABLE_TELEMETRY key (UnorderedKey) 🤖 Prompt for AI Agents |
||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| name: nx | ||
|
|
||
| on: | ||
| push: | ||
coderabbitai[bot] marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| permissions: | ||
| actions: read | ||
| contents: read | ||
|
|
||
| jobs: | ||
| nx: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| filter: tree:0 | ||
| fetch-depth: 0 | ||
| - run: npx nx@latest start-ci-run --distribute-on="20 my-linux-extra-large-plus-js" --stop-agents-after="check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,vitest,playwright-ct,cypress" | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22 | ||
| cache: 'yarn' | ||
| - run: yarn install --immutable | ||
| - uses: nrwl/nx-set-shas@v4 | ||
| - run: yarn nx run-many --parallel=1 -t check,knip,test,pretty-docs,lint,test,sandbox,build-sandbox,e2e-tests,e2e-tests-dev,test-runner,vitest-integration,check-sandbox,e2e-ui,jest,vitest,playwright-ct,cypress -c production -p="tag:ci:normal,tag:ci:merged,tag:ci:daily" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,2 @@ | ||
| 22.21.1 | ||
|
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.