Skip to content

Notes and Presenter View: long notes scroll, presenter controls show (#221) - #224

Merged
h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
justinjohn0306:issue-221-notes-and-presenter
Oct 14, 2026
Merged

h-a-n-a-s-h-i merged 1 commit into
storytold:mainfrom
justinjohn0306:issue-221-notes-and-presenter

Conversation

@justinjohn0306

Copy link
Copy Markdown
Contributor

Fixes the two bugs in #221; likely also what #202 ("presenter view doesn't work") ran into.

1. Long speaker notes spill over the slide. The notes TextEdit wasn't in a scroll area, so a long note drew above its pane and over the slide (and stretched the pane, whose height is saved). It now scrolls inside the pane at the pane's height.

2. Presenter View "has no buttons". The buttons were there but invisible: the default (light-theme) button text is dark grey on the presenter window's near-black background. They now draw light text on a visible fill. The issue also asks to pause and restart the timer, so the timer gets Pause / Resume and Reset.

Not in this PR: rearranging the presenter layout (moving the notes relative to the next-slide preview).

Verified in the running app (Windows, --sample, control channel + real mouse clicks on the presenter window):

  • 40 lines of notes: before, they covered the bottom of the slide; after, they scroll inside the default-height pane and the slide is untouched.
  • Presenter View: before, the controls were barely visible top-right; after, they are clearly drawn. Clicking Next builds the next bullet / slide, Pause freezes the timer (same value 4 s later) and turns into Resume, and Reset sets it to 00:00:00.
  • New presenter_timer_pauses_resumes_and_resets test; cargo xtask ci: all 6 steps pass.

On a single monitor the full-screen show covers the presenter window (it has to be brought forward). Putting the show on the second monitor for #202 isn't covered here; I only have one monitor to test with.

🤖 Generated with Claude Code

…torytold#221)

Long speaker notes grew out of the notes pane and over the slide: the
editor now scrolls inside the pane. In Presenter View the Previous, Next
and End Show buttons drew dark text on the dark window, so they looked
missing; they are now light on a visible fill, and the timer gets Pause /
Resume and Reset.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@h-a-n-a-s-h-i
h-a-n-a-s-h-i merged commit d2bf428 into storytold:main Oct 14, 2026
h-a-n-a-s-h-i pushed a commit that referenced this pull request Oct 14, 2026
…ntegrated on land-r3 (#518 #531 #535 #533 #572 #573 #577 #580 #583 #592 #685 #528 #483 #490 #441 #671 #679 #649 #656 #660 #664 #224)

# Conflicts:
#	crates/engine/src/tests.rs
#	crates/model/src/lib.rs
#	crates/pptx/src/write/mod.rs
#	crates/render/src/lib.rs
#	crates/ui-egui/src/canvas.rs
#	crates/ui-egui/src/lib.rs
#	crates/ui-egui/src/thumbs.rs
@echelon

echelon commented Oct 14, 2026

Copy link
Copy Markdown
Member

Thank you for this contribution, @justinjohn0306! It has landed on main and will ship in the next DeckCraft release.

If you haven't already, please come join us on Discord: https://discord.gg/artcraft

@Azithro721

Copy link
Copy Markdown

Kindly improve the performance of presenter view mode it's very buggy and slow.
Also add Arrow keys ← & → to navigate pages, arrow keys ↑&↓ to scroll the notes. And key 'P' to play/pause video in presenter view. Red glowy Pointer option.

I love this project I'm on omarchy Linux using this app. Earlier i had presenter view issues in libre office and those bugs were never fixed so there was no any better alt so I had to switch to windows... Now finally cuz of this project i can use linux.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants