Repository navigation
Notes and Presenter View: long notes scroll, presenter controls show (#221) - #224
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 14, 2026
Conversation
…torytold#221) Long speaker notes grew out of the notes pane and over the slide: the editor now scrolls inside the pane. In Presenter View the Previous, Next and End Show buttons drew dark text on the dark window, so they looked missing; they are now light on a visible fill, and the timer gets Pause / Resume and Reset. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
…ntegrated on land-r3 (#518 #531 #535 #533 #572 #573 #577 #580 #583 #592 #685 #528 #483 #490 #441 #671 #679 #649 #656 #660 #664 #224) # Conflicts: # crates/engine/src/tests.rs # crates/model/src/lib.rs # crates/pptx/src/write/mod.rs # crates/render/src/lib.rs # crates/ui-egui/src/canvas.rs # crates/ui-egui/src/lib.rs # crates/ui-egui/src/thumbs.rs
Member
|
Thank you for this contribution, @justinjohn0306! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
|
Kindly improve the performance of presenter view mode it's very buggy and slow. I love this project I'm on omarchy Linux using this app. Earlier i had presenter view issues in libre office and those bugs were never fixed so there was no any better alt so I had to switch to windows... Now finally cuz of this project i can use linux. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the two bugs in #221; likely also what #202 ("presenter view doesn't work") ran into.
1. Long speaker notes spill over the slide. The notes
TextEditwasn't in a scroll area, so a long note drew above its pane and over the slide (and stretched the pane, whose height is saved). It now scrolls inside the pane at the pane's height.2. Presenter View "has no buttons". The buttons were there but invisible: the default (light-theme) button text is dark grey on the presenter window's near-black background. They now draw light text on a visible fill. The issue also asks to pause and restart the timer, so the timer gets Pause / Resume and Reset.
Not in this PR: rearranging the presenter layout (moving the notes relative to the next-slide preview).
Verified in the running app (Windows,
--sample, control channel + real mouse clicks on the presenter window):presenter_timer_pauses_resumes_and_resetstest;cargo xtask ci: all 6 steps pass.On a single monitor the full-screen show covers the presenter window (it has to be brought forward). Putting the show on the second monitor for #202 isn't covered here; I only have one monitor to test with.
🤖 Generated with Claude Code