Repository navigation
Media: keep playback with the document and the clip (#415) - #483
Merged
h-a-n-a-s-h-i merged 1 commit intoOct 14, 2026
Merged
Conversation
Shape ids are local to one presentation, and decoded audio was cached by the address of a buffer the cache did not keep. Switching decks, closing the last one, or replacing a clip could keep the previous sound. Playback now stops when the document changes or closes, a new source replaces the voice's audio, and the decode and duration caches hold the bytes they are keyed by. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Thank you for this contribution, @NikitkaRa! It has landed on If you haven't already, please come join us on Discord: https://discord.gg/artcraft |
h-a-n-a-s-h-i
pushed a commit
that referenced
this pull request
Oct 14, 2026
…ntegrated on land-r3 (#518 #531 #535 #533 #572 #573 #577 #580 #583 #592 #685 #528 #483 #490 #441 #671 #679 #649 #656 #660 #664 #224) # Conflicts: # crates/engine/src/tests.rs # crates/model/src/lib.rs # crates/pptx/src/write/mod.rs # crates/render/src/lib.rs # crates/ui-egui/src/canvas.rs # crates/ui-egui/src/lib.rs # crates/ui-egui/src/thumbs.rs
3 tasks done
anishguduru
pushed a commit
to anishguduru/deckcraft
that referenced
this pull request
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo test -p deckcraft-media --lib player::tests(including replacement of a voice's source, retained cache bytes, and resume of the same source)cargo test -p deckcraft-ui-egui --lib media::tests(two decks with the same shape id, clip replacement, last-document close, GIF clocks)cargo clippy -p deckcraft-media -p deckcraft-ui-egui --all-targets -- -D warningscargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings,cargo xtask assets,cargo xtask layers,cargo xtask wasmcargo test --workspacealso runsdeckcraft-textsymbol_font_characters_draw_in_the_sym_font, which fails on this machine because Wingdings 2 is installed and claims U+F0DE. That crate is unchanged.Closes #415